chrome/browser/resources/settings/people_page/people_page.js - Issue 1575543003: Settings People Revamp: Implement parts of ChromeOS Change Picture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/people_page.js

Issue 1575543003: Settings People Revamp: Implement parts of ChromeOS Change Picture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix change_picture_handler to accomodate origin/master changes Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/people_page/people_page.html ('k') | chrome/browser/resources/settings/people_page/sync_private_api.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/people_page.js

diff --git a/chrome/browser/resources/settings/people_page/people_page.js b/chrome/browser/resources/settings/people_page/people_page.js

index a78e2425d00087bcb0cce2a4533bf45553922d2b..8dc0afbb1004ad42a7b0ec6400ecafccc4dd8be3 100644

--- a/chrome/browser/resources/settings/people_page/people_page.js

+++ b/chrome/browser/resources/settings/people_page/people_page.js

@@ -95,13 +95,22 @@ Polymer({

/** @private */

- onManageProfileTap_: function() {

+ onPictureTap_: function() {

+<if expr="chromeos">

+ this.$.pages.setSubpageChain(['changePicture']);

+</if>

this.$.pages.setSubpageChain(['manageProfile']);

</if>

- // TODO(tommycli): Implement ChromeOS version. January 2016.

+<if expr="not chromeos">

+ /** @private */

+ onProfileNameTap_: function() {

+ this.$.pages.setSubpageChain(['manageProfile']);

+ },

+</if>

/** @private */

onSigninTap_: function() {

settings.SyncPrivateApi.startSignIn();