chrome/browser/ui/webui/settings/md_settings_ui.cc - Issue 1575543003: Settings People Revamp: Implement parts of ChromeOS Change Picture

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_ui.cc

Issue 1575543003: Settings People Revamp: Implement parts of ChromeOS Change Picture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: refactor Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('K') | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_ui.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_ui.cc b/chrome/browser/ui/webui/settings/md_settings_ui.cc

index 6138db26c734f542933fe10510ba527bc607938b..fa207e9951b5ba95b977ffc14c9e91b6704451d4 100644

--- a/chrome/browser/ui/webui/settings/md_settings_ui.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_ui.cc

@@ -26,9 +26,11 @@

#include "grit/settings_resources.h"

#include "grit/settings_resources_map.h"

-#if !defined(OS_CHROMEOS)

+#if defined(OS_CHROMEOS)

+#include "chrome/browser/ui/webui/settings/chromeos/change_picture_handler.h"

+#else // !defined(OS_CHROMEOS)

#include "chrome/browser/ui/webui/settings/settings_manage_profile_handler.h"

-#endif

+#endif // defined(OS_CHROMEOS)

namespace settings {

@@ -50,7 +52,9 @@ MdSettingsUI::MdSettingsUI(content::WebUI* web_ui)

AddSettingsPageUIHandler(new PeopleHandler(profile));

AddSettingsPageUIHandler(new StartupPagesHandler(web_ui));

-#if !defined(OS_CHROMEOS)

+#if defined(OS_CHROMEOS)

+ AddSettingsPageUIHandler(new chromeos::settings::ChangePictureHandler);

dpapad 2016/01/13 19:00:07 Nit: Is it allowed to omit the () for no-arg const

tommycli 2016/01/13 19:35:17 Done. You're right, I think 'new Foo()' is more st

+#else

AddSettingsPageUIHandler(new ManageProfileHandler(profile));

#endif