Settings People Revamp: Implement parts of ChromeOS Change Picture

chrome/browser/resources/settings/people_page/change_picture.js

Index: chrome/browser/resources/settings/people_page/change_picture.js
diff --git a/chrome/browser/resources/settings/people_page/change_picture.js b/chrome/browser/resources/settings/people_page/change_picture.js
new file mode 100644
index 0000000000000000000000000000000000000000..5fe931b3e17d7af1aa6931e1980dd019a396f92a
--- /dev/null
+++ b/chrome/browser/resources/settings/people_page/change_picture.js
@@ -0,0 +1,168 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @fileoverview
+ * 'settings-change-picture' is the settings subpage containing controls to
+ * edit a ChromeOS user's picture.
+ *
+ * @group Chrome Settings Elements
+ * @element settings-change-picture
+ */
+Polymer({
+  is: 'settings-change-picture',
+
+  behaviors: [
+    I18nBehavior,
+  ],
+
+  properties: {
+    /**
+     * The currently selected profile image URL. May be a data URL.
+     * @private {string}
+     */
+    selectedImageUrl_: String,
+
+    /**
+     * The url of the 'old' image, which is the existing image sourced from
+     * the camera, a file, or a deprecated default image.
+     * @private {string}
+     */
+    oldImageUrl_: String,
+
+    /**
+     * The url of the profile image.
+     * @private {string}
+     */
+    profileImageUrl_: {
+      type: String,
+      value: settings.ChangePicturePrivateApi.ButtonImages.PROFILE_PICTURE,
+    },
+
+    /**
+     * The default user images. Populated by ChangePicturePrivateApi.
+     * @private {!Array<!settings.DefaultImage>}
+     */
+    defaultImages_: {
+      type: Array,
+      value: function() { return []; },
+    },
+  },
+
+  /** @override */
+  attached: function() {
+    // This is the interface called by the C++ handler.
+    var nativeInterface = {
+      /**
+       * Called from C++ to provide the default set of images.
+       * @param {!Array<!settings.DefaultImage>} images
+       */
+      receiveDefaultImages: function(images) {
+        this.defaultImages_ = images;
+      }.bind(this),
+
+      /**
+       * Called from C++ to provide the URL of the selected image.
+       * @param {string} imageUrl
+       */
+      receiveSelectedImage: function(imageUrl) {
+        this.selectedImageUrl_ = imageUrl;
+      }.bind(this),
+
+      /**
+       * Called from C++ to provide the URL of the 'old' image. The 'old'
+       * image is any selected non-profile and non-default image. It can be
+       * from the camera, a file, or a deprecated default image. When this
+       * method is called, it's implied that the old image is selected.
+       * @param {string} imageUrl
+       */
+      receiveOldImage: function(imageUrl) {
+        this.oldImageUrl_ = imageUrl;
+        this.selectedImageUrl_ = imageUrl;
+      }.bind(this),
+
+      /**
+       * Called from C++ to provide the URL of the profile image.
+       * @param {string} imageUrl
+       * @param {boolean} selected
+       */
+      receiveProfileImage: function(imageUrl, selected) {
+        this.profileImageUrl_ = imageUrl;
+        if (selected)
+          this.selectedImageUrl_ = imageUrl;
+      }.bind(this),
+
+      /**
+       * Called from the C++ to notify page about camera presence.
+       * @param {boolean} cameraPresent
+       */
+      receiveCameraPresence: function(cameraPresent) {
+        // TODO(tommycli): Implement camera functionality.
+      }.bind(this),
+    };
+
+    cr.define('settings', function() {
+      var ChangePicturePage = nativeInterface;

[dpapad, 2016/01/13 19:00:07]

Nit: Does the compiler complain if you do directly the following

cr.define('settings', function() {
  return {
    ChangePicturePage: nativeInterface,
  };
});

[tommycli, 2016/01/13 19:35:17]

Exactly. That's what I had initially, but I get

##
/mnt/src/chromium/src/chrome/browser/resources/settings/people_page/change_picture.js:107:
ERROR - Property ChangePicturePage never defined on settings
##         ChangePicturePage: nativeInterface,

I have no idea why.

+      return {
+        ChangePicturePage: ChangePicturePage,
+      };
+    });
+
+    settings.ChangePicturePrivateApi.initialize();
+  },
+
+  /**
+   * Handler for when the user clicks a new profile image.
+   * @private
+   * @param {!Event} event
+   */
+  onDefaultImageTap_: function(event) {
+    var element = Polymer.dom(event).rootTarget;
+
+    var imageUrl = null;
+    if (element.nodeName == 'IMG')
+      imageUrl = element.src;
+    else if (element.dataset && element.dataset.imageUrl)
+      imageUrl = element.dataset.imageUrl;
+
+    if (imageUrl != null) {
+      settings.ChangePicturePrivateApi.selectDefaultImage(imageUrl);
+      // Button toggle state is instead controlled by the selected image URL.
+      event.preventDefault();
+    }
+  },
+
+  /**
+   * Handler for when the user clicks the 'old' image.
+   * @private
+   * @param {!Event} event
+   */
+  onOldImageTap_: function(event) {
+    settings.ChangePicturePrivateApi.selectOldImage();
+    // Button toggle state is instead controlled by the selected image URL.
+    event.preventDefault();
+  },
+
+  /**
+   * Handler for when the user clicks the 'profile' image.
+   * @private
+   * @param {!Event} event
+   */
+  onProfileImageTap_: function(event) {
+    settings.ChangePicturePrivateApi.selectProfileImage();
+    // Button toggle state is instead controlled by the selected image URL.
+    event.preventDefault();
+  },
+
+  /**
+   * Computed binding determining which profile image button is toggled on.
+   * @private
+   * @param {string} imageUrl
+   * @param {string} selectedImageUrl
+   * @return {boolean}
+   */
+  isActiveImage_: function(imageUrl, selectedImageUrl) {
+    return imageUrl == selectedImageUrl;
+  },
+});