Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 1575543003: Settings People Revamp: Implement parts of ChromeOS Change Picture (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix change_picture_handler to accomodate origin/master changes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-router' is a simple router for settings. Its responsibilities: 7 * 'settings-router' is a simple router for settings. Its responsibilities:
8 * - Update the URL when the routing state changes. 8 * - Update the URL when the routing state changes.
9 * - Initialize the routing state with the initial URL. 9 * - Initialize the routing state with the initial URL.
10 * - Process and validate all routing state changes. 10 * - Process and validate all routing state changes.
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 subpage: ['search-engines'], 125 subpage: ['search-engines'],
126 subpageTitles: ['searchEnginesPageTitle'], 126 subpageTitles: ['searchEnginesPageTitle'],
127 }, 127 },
128 { 128 {
129 url: '/searchEngines/advanced', 129 url: '/searchEngines/advanced',
130 page: 'basic', 130 page: 'basic',
131 section: 'search', 131 section: 'search',
132 subpage: ['search-engines', 'search-engines-advanced'], 132 subpage: ['search-engines', 'search-engines-advanced'],
133 subpageTitles: ['searchEnginesPageTitle', 'advancedPageTitle'], 133 subpageTitles: ['searchEnginesPageTitle', 'advancedPageTitle'],
134 }, 134 },
135 <if expr="chromeos">
136 {
137 url: '/changePicture',
138 page: 'basic',
139 section: 'people',
140 subpage: ['changePicture'],
141 subpageTitles: ['changePictureTitle'],
142 },
143 </if>
135 <if expr="not chromeos"> 144 <if expr="not chromeos">
136 { 145 {
137 url: '/manageProfile', 146 url: '/manageProfile',
138 page: 'basic', 147 page: 'basic',
139 section: 'people', 148 section: 'people',
140 subpage: ['manageProfile'], 149 subpage: ['manageProfile'],
141 subpageTitles: ['editPerson'], 150 subpageTitles: ['editPerson'],
142 }, 151 },
143 </if> 152 </if>
144 { 153 {
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 window.history.replaceState(historicState, document.title); 356 window.history.replaceState(historicState, document.title);
348 } 357 }
349 358
350 return; 359 return;
351 } 360 }
352 } 361 }
353 362
354 assertNotReached('Route not found: ' + JSON.stringify(newRoute)); 363 assertNotReached('Route not found: ' + JSON.stringify(newRoute));
355 }, 364 },
356 }); 365 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698