Source/core/rendering/RenderLayer.cpp - Issue 157553002: Remove the Pagination struct, clean up viewport scroll policy propagation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 157553002: Remove the Pagination struct, clean up viewport scroll policy propagation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderLayer.cpp

diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp

index 619dfa26a3c3979195ca1e96e9df2df673b1d2dd..9d69ad5200171c7e2342e77a1fe97d2fae90cebc 100644

--- a/Source/core/rendering/RenderLayer.cpp

+++ b/Source/core/rendering/RenderLayer.cpp

@@ -3720,7 +3720,7 @@ inline bool RenderLayer::needsCompositingLayersRebuiltForClip(const RenderStyle*

inline bool RenderLayer::needsCompositingLayersRebuiltForOverflow(const RenderStyle* oldStyle, const RenderStyle* newStyle) const

{

ASSERT(newStyle);

- return !hasCompositedLayerMapping() && oldStyle && (oldStyle->overflowX() != newStyle->overflowX()) && m_stackingNode->ancestorStackingContainerNode()->layer()->hasCompositingDescendant();

+ return !hasCompositedLayerMapping() && oldStyle && (oldStyle->overflowX() != newStyle->overflowX()) && m_stackingNode->ancestorStackingContainerNode() && m_stackingNode->ancestorStackingContainerNode()->layer()->hasCompositingDescendant();

rune 2014/02/07 16:44:27 Is it time to split this statement across multiple

mstensho (USE GERRIT) 2014/02/11 10:44:14 Done.

}

inline bool RenderLayer::needsCompositingLayersRebuiltForFilters(const RenderStyle* oldStyle, const RenderStyle* newStyle, bool didPaintWithFilters) const

« Source/core/rendering/RenderBlock.cpp ('K') | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderLayerScrollableArea.cpp » ('j') | no next file with comments »