LayoutTests/fast/pagination/body-make-paginated.html - Issue 157553002: Remove the Pagination struct, clean up viewport scroll policy propagation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/pagination/body-make-paginated.html

Issue 157553002: Remove the Pagination struct, clean up viewport scroll policy propagation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/overflow/scroll-html-paged-body-expected.html ('k') | LayoutTests/fast/pagination/body-make-paginated-expected.html » ('j') | Source/core/dom/Document.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Dynamically set paged overflow on the body element</title>

	5 <script>

	6 function test() {

	7 document.body.offsetWidth; // trigger layout
	ojan 2014/02/08 01:40:19 Nit: I've lately been encouraging people to use of Nit: I've lately been encouraging people to use offsetTop. In theory, we might put an optimization in the future that we don't do a layout on offsetWidth if the element has a fixed width. Although, I guess that doesn't really apply here anyways. mstensho (USE GERRIT) 2014/02/11 10:44:14 Done. In this case it doesn't really matter, no, b Show quoted text On 2014/02/08 01:40:19, ojan wrote: > Nit: I've lately been encouraging people to use offsetTop. In theory, we might > put an optimization in the future that we don't do a layout on offsetWidth if > the element has a fixed width. Although, I guess that doesn't really apply here > anyways. Done. In this case it doesn't really matter, no, but I'll hopefully remember this for the future now. :)
	8 document.body.style.overflow = '-webkit-paged-x';

	9 document.body.style.overflow = 'paged-x';

	10 }

	11 </script>

	12 </head>

	13 <body onload="test()">

	14 <div style="height:150vh;">

	15 There should be no text below.

	16 <div style="-webkit-column-break-before:always;">FAIL</div>

	17 </div>

	18 </body>

	19 </html>

OLD	NEW