extensions/browser/updater/update_service_unittest.cc - Issue 1575523002: Comparison and streaming operators for base::Version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/updater/update_service_unittest.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes mistake in previous patch set. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/updater/update_service_unittest.cc

diff --git a/extensions/browser/updater/update_service_unittest.cc b/extensions/browser/updater/update_service_unittest.cc

index a6ed8b7f844915040e0e4a0061c2c266207d8d78..94bfad39dbcdb5cf49043922c70c78fdf8946b5e 100644

--- a/extensions/browser/updater/update_service_unittest.cc

+++ b/extensions/browser/updater/update_service_unittest.cc

@@ -203,7 +203,7 @@ TEST_F(UpdateServiceTest, BasicUpdateOperations) {

ASSERT_NE(nullptr, data);

ASSERT_EQ(1u, data->size());

- ASSERT_TRUE(data->at(0).version.Equals(*extension1->version()));

+ ASSERT_EQ(data->at(0).version, *extension1->version());

update_client::CrxInstaller* installer = data->at(0).installer.get();

ASSERT_NE(installer, nullptr);

« no previous file with comments | « extensions/browser/content_hash_reader.cc ('k') | gpu/config/gpu_info_collector_win.cc » ('j') | no next file with comments »