Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4296)

Unified Diff: chrome/browser/extensions/extension_sync_data_unittest.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes mistake in previous patch set. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_sync_data_unittest.cc
diff --git a/chrome/browser/extensions/extension_sync_data_unittest.cc b/chrome/browser/extensions/extension_sync_data_unittest.cc
index bae256ffe3abb3a297374821e4e23e240c68dfaa..a271125e82b335c13223a69130843c5b217d6921 100644
--- a/chrome/browser/extensions/extension_sync_data_unittest.cc
+++ b/chrome/browser/extensions/extension_sync_data_unittest.cc
@@ -70,7 +70,7 @@ void SyncDataToProtobufEqual(const ExtensionSyncData& input) {
EXPECT_EQ(input.remote_install(), output->remote_install());
EXPECT_EQ(input.installed_by_custodian(), output->installed_by_custodian());
EXPECT_EQ(input.all_urls_enabled(), output->all_urls_enabled());
- EXPECT_TRUE(input.version().Equals(output->version()));
+ EXPECT_EQ(input.version(), output->version());
EXPECT_EQ(input.update_url(), output->update_url());
EXPECT_EQ(input.name(), output->name());
}
@@ -110,7 +110,7 @@ TEST_F(ExtensionSyncDataTest, ExtensionSyncDataForExtension) {
EXPECT_FALSE(extension_sync_data.remote_install());
EXPECT_EQ(ExtensionSyncData::BOOLEAN_TRUE,
extension_sync_data.all_urls_enabled());
- EXPECT_TRUE(Version(kVersion).Equals(extension_sync_data.version()));
+ EXPECT_EQ(Version(kVersion), extension_sync_data.version());
EXPECT_EQ(std::string(kName), extension_sync_data.name());
// Check the serialize-deserialize process for ExtensionSyncData to proto.
« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_sync_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698