Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: chrome/browser/extensions/extension_service_sync_unittest.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes mistake in previous patch set. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_sync_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_sync_unittest.cc b/chrome/browser/extensions/extension_service_sync_unittest.cc
index a9a05d8162addb858206e739384dfa7f70017165..9c553506c179a9b59eeff61a0ca666574993a509 100644
--- a/chrome/browser/extensions/extension_service_sync_unittest.cc
+++ b/chrome/browser/extensions/extension_service_sync_unittest.cc
@@ -407,7 +407,7 @@ TEST_F(ExtensionServiceSyncTest, GetSyncData) {
EXPECT_EQ(extensions::util::IsIncognitoEnabled(good_crx, profile()),
data->incognito_enabled());
EXPECT_EQ(ExtensionSyncData::BOOLEAN_UNSET, data->all_urls_enabled());
- EXPECT_TRUE(data->version().Equals(*extension->version()));
+ EXPECT_EQ(data->version(), *extension->version());
EXPECT_EQ(extensions::ManifestURL::GetUpdateURL(extension),
data->update_url());
EXPECT_EQ(extension->name(), data->name());
@@ -508,7 +508,7 @@ TEST_F(ExtensionServiceSyncTest, GetSyncDataTerminated) {
EXPECT_EQ(extensions::util::IsIncognitoEnabled(good_crx, profile()),
data->incognito_enabled());
EXPECT_EQ(ExtensionSyncData::BOOLEAN_UNSET, data->all_urls_enabled());
- EXPECT_TRUE(data->version().Equals(*extension->version()));
+ EXPECT_EQ(data->version(), *extension->version());
EXPECT_EQ(extensions::ManifestURL::GetUpdateURL(extension),
data->update_url());
EXPECT_EQ(extension->name(), data->name());
@@ -1061,7 +1061,7 @@ TEST_F(ExtensionServiceSyncTest, ProcessSyncDataVersionCheck) {
scoped_ptr<ExtensionSyncData> extension_data =
ExtensionSyncData::CreateFromSyncData(data[0]);
ASSERT_TRUE(extension_data);
- EXPECT_TRUE(installed_version.Equals(extension_data->version()));
+ EXPECT_EQ(installed_version, extension_data->version());
}
// Should do nothing if extension version > sync version.
@@ -1080,7 +1080,7 @@ TEST_F(ExtensionServiceSyncTest, ProcessSyncDataVersionCheck) {
scoped_ptr<ExtensionSyncData> extension_data =
ExtensionSyncData::CreateFromSyncData(data[0]);
ASSERT_TRUE(extension_data);
- EXPECT_TRUE(installed_version.Equals(extension_data->version()));
+ EXPECT_EQ(installed_version, extension_data->version());
}
// Should kick off an update if extension version < sync version.
@@ -1102,7 +1102,7 @@ TEST_F(ExtensionServiceSyncTest, ProcessSyncDataVersionCheck) {
scoped_ptr<ExtensionSyncData> extension_data =
ExtensionSyncData::CreateFromSyncData(data[0]);
ASSERT_TRUE(extension_data);
- EXPECT_TRUE(new_version.Equals(extension_data->version()));
+ EXPECT_EQ(new_version, extension_data->version());
}
EXPECT_FALSE(service()->pending_extension_manager()->IsIdPending(good_crx));
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698