components/variations/service/variations_service.cc - Issue 1575523002: Comparison and streaming operators for base::Version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/variations/service/variations_service.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/component_updater/default_component_installer.cc ('K') | « components/update_client/update_client_unittest.cc ('k') | extensions/browser/content_hash_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/variations/service/variations_service.cc

diff --git a/components/variations/service/variations_service.cc b/components/variations/service/variations_service.cc

index 3d41ce3c7643455d971fba59b1625bf29c4af07b..c68176ea9cfbf05c663e244e1d8f7c8f3e834bd4 100644

--- a/components/variations/service/variations_service.cc

+++ b/components/variations/service/variations_service.cc

@@ -799,7 +799,7 @@ std::string VariationsService::LoadPermanentConsistencyCountry(

// Determine if the version from the saved pref matches |version|.

const bool does_version_match =

- is_pref_valid && version.Equals(base::Version(stored_version_string));

+ is_pref_valid && version == base::Version(stored_version_string);

// Determine if the country in the saved pref matches the country in

// |latest_country|.