Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: chrome/browser/ui/startup/default_browser_prompt.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/default_browser_prompt.cc
diff --git a/chrome/browser/ui/startup/default_browser_prompt.cc b/chrome/browser/ui/startup/default_browser_prompt.cc
index 9443190fb389a0fbd08a4b9841b19c5d33bbfcce..c3026c2bf3ac3589d06c8bc6b0c0f9675523c265 100644
--- a/chrome/browser/ui/startup/default_browser_prompt.cc
+++ b/chrome/browser/ui/startup/default_browser_prompt.cc
@@ -308,9 +308,9 @@ void ShowDefaultBrowserPrompt(Profile* profile, HostDesktopType desktop_type) {
prefs::kBrowserSuppressDefaultBrowserPrompt);
const Version disable_version(disable_version_string);
DCHECK(disable_version_string.empty() || disable_version.IsValid());
- if (disable_version.IsValid()) {
- if (disable_version.Equals(Version(version_info::GetVersionNumber())))
- show_prompt = false;
+ if (disable_version.IsValid() &&
+ disable_version == Version(version_info::GetVersionNumber())) {
+ show_prompt = false;
}
}

Powered by Google App Engine
This is Rietveld 408576698