chrome/browser/extensions/extension_service.cc - Issue 1575523002: Comparison and streaming operators for base::Version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/version.cc ('K') | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_service_sync_unittest.cc » ('j') | chrome/common/chrome_content_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 89d5dec1daf6c688f9870b80b6b6e77380be90b3..e2aacb32e64347a6ad062b2265991645f8161e31 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -1530,7 +1530,7 @@ void ExtensionService::AddComponentExtension(const Extension* extension) {

const Version old_version(old_version_string);

VLOG(1) << "AddComponentExtension " << extension->name();

- if (!old_version.IsValid() || !old_version.Equals(*extension->version())) {

+ if (!old_version.IsValid() || old_version != *extension->version()) {

VLOG(1) << "Component extension " << extension->name() << " ("

<< extension->id() << ") installing/upgrading from '"

<< old_version_string << "' to " << extension->version()->GetString();