Comparison and streaming operators for base::Version

chrome/browser/extensions/chrome_extensions_browser_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/chrome_extensions_browser_client.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/version.h"
@@ skipping 195 matching lines @@
     return false;
 
   PrefService* pref_service = extension_prefs->pref_service();
   base::Version last_version;
   if (pref_service->HasPrefPath(pref_names::kLastChromeVersion)) {
     std::string last_version_str =
         pref_service->GetString(pref_names::kLastChromeVersion);
     last_version = base::Version(last_version_str);
   }
 
-  std::string current_version = version_info::GetVersionNumber();
-  pref_service->SetString(pref_names::kLastChromeVersion,
-                          current_version);
+  std::string current_version_str = version_info::GetVersionNumber();
+  base::Version current_version(current_version_str);
+  pref_service->SetString(pref_names::kLastChromeVersion, current_version_str);
 
   // If there was no version string in prefs, assume we're out of date.
   if (!last_version.IsValid())
     return true;
+  // If the current version string is invalid, assume we didn't update.
+  if (!current_version.IsValid())
+    return false;
 
-  return last_version.IsOlderThan(current_version);
+  return last_version < current_version;
 }
 
 void ChromeExtensionsBrowserClient::PermitExternalProtocolHandler() {
   ExternalProtocolHandler::PermitLaunchUrl();
 }
 
 bool ChromeExtensionsBrowserClient::IsRunningInForcedAppMode() {
   return chrome::IsRunningInForcedAppMode();
 }
 
@@ skipping 153 matching lines @@
 }
 
 scoped_refptr<update_client::UpdateClient>
 ChromeExtensionsBrowserClient::CreateUpdateClient(
     content::BrowserContext* context) {
   return update_client::UpdateClientFactory(
       make_scoped_refptr(new ChromeUpdateClientConfig(context)));
 }
 
 }  // namespace extensions