Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Side by Side Diff: components/update_client/update_client_unittest.cc

Issue 1575523002: Comparison and streaming operators for base::Version (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <utility> 5 #include <utility>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 }; 412 };
413 413
414 class FakePingManager : public FakePingManagerImpl { 414 class FakePingManager : public FakePingManagerImpl {
415 public: 415 public:
416 explicit FakePingManager(const Configurator& config) 416 explicit FakePingManager(const Configurator& config)
417 : FakePingManagerImpl(config) {} 417 : FakePingManagerImpl(config) {}
418 ~FakePingManager() override { 418 ~FakePingManager() override {
419 const auto& ping_items = items(); 419 const auto& ping_items = items();
420 EXPECT_EQ(1U, ping_items.size()); 420 EXPECT_EQ(1U, ping_items.size());
421 EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_items[0].id); 421 EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_items[0].id);
422 EXPECT_TRUE(base::Version("0.9").Equals(ping_items[0].previous_version)); 422 EXPECT_EQ(base::Version("0.9"), ping_items[0].previous_version);
423 EXPECT_TRUE(base::Version("1.0").Equals(ping_items[0].next_version)); 423 EXPECT_EQ(base::Version("1.0"), ping_items[0].next_version);
424 EXPECT_EQ(0, ping_items[0].error_category); 424 EXPECT_EQ(0, ping_items[0].error_category);
425 EXPECT_EQ(0, ping_items[0].error_code); 425 EXPECT_EQ(0, ping_items[0].error_code);
426 } 426 }
427 }; 427 };
428 428
429 scoped_ptr<PingManager> ping_manager(new FakePingManager(*config())); 429 scoped_ptr<PingManager> ping_manager(new FakePingManager(*config()));
430 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl( 430 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl(
431 config(), std::move(ping_manager), &FakeUpdateChecker::Create, 431 config(), std::move(ping_manager), &FakeUpdateChecker::Create,
432 &FakeCrxDownloader::Create)); 432 &FakeCrxDownloader::Create));
433 433
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
635 }; 635 };
636 636
637 class FakePingManager : public FakePingManagerImpl { 637 class FakePingManager : public FakePingManagerImpl {
638 public: 638 public:
639 explicit FakePingManager(const Configurator& config) 639 explicit FakePingManager(const Configurator& config)
640 : FakePingManagerImpl(config) {} 640 : FakePingManagerImpl(config) {}
641 ~FakePingManager() override { 641 ~FakePingManager() override {
642 const auto& ping_items = items(); 642 const auto& ping_items = items();
643 EXPECT_EQ(2U, ping_items.size()); 643 EXPECT_EQ(2U, ping_items.size());
644 EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_items[0].id); 644 EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_items[0].id);
645 EXPECT_TRUE(base::Version("0.9").Equals(ping_items[0].previous_version)); 645 EXPECT_EQ(base::Version("0.9"), ping_items[0].previous_version);
646 EXPECT_TRUE(base::Version("1.0").Equals(ping_items[0].next_version)); 646 EXPECT_EQ(base::Version("1.0"), ping_items[0].next_version);
647 EXPECT_EQ(0, ping_items[0].error_category); 647 EXPECT_EQ(0, ping_items[0].error_category);
648 EXPECT_EQ(0, ping_items[0].error_code); 648 EXPECT_EQ(0, ping_items[0].error_code);
649 EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_items[1].id); 649 EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_items[1].id);
650 EXPECT_TRUE(base::Version("0.8").Equals(ping_items[1].previous_version)); 650 EXPECT_EQ(base::Version("0.8"), ping_items[1].previous_version);
651 EXPECT_TRUE(base::Version("1.0").Equals(ping_items[1].next_version)); 651 EXPECT_EQ(base::Version("1.0"), ping_items[1].next_version);
652 EXPECT_EQ(0, ping_items[1].error_category); 652 EXPECT_EQ(0, ping_items[1].error_category);
653 EXPECT_EQ(0, ping_items[1].error_code); 653 EXPECT_EQ(0, ping_items[1].error_code);
654 } 654 }
655 }; 655 };
656 656
657 scoped_ptr<FakePingManager> ping_manager(new FakePingManager(*config())); 657 scoped_ptr<FakePingManager> ping_manager(new FakePingManager(*config()));
658 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl( 658 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl(
659 config(), std::move(ping_manager), &FakeUpdateChecker::Create, 659 config(), std::move(ping_manager), &FakeUpdateChecker::Create,
660 &FakeCrxDownloader::Create)); 660 &FakeCrxDownloader::Create));
661 661
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
873 }; 873 };
874 874
875 class FakePingManager : public FakePingManagerImpl { 875 class FakePingManager : public FakePingManagerImpl {
876 public: 876 public:
877 explicit FakePingManager(const Configurator& config) 877 explicit FakePingManager(const Configurator& config)
878 : FakePingManagerImpl(config) {} 878 : FakePingManagerImpl(config) {}
879 ~FakePingManager() override { 879 ~FakePingManager() override {
880 const auto& ping_items = items(); 880 const auto& ping_items = items();
881 EXPECT_EQ(2U, ping_items.size()); 881 EXPECT_EQ(2U, ping_items.size());
882 EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_items[0].id); 882 EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_items[0].id);
883 EXPECT_TRUE(base::Version("0.9").Equals(ping_items[0].previous_version)); 883 EXPECT_EQ(base::Version("0.9"), ping_items[0].previous_version);
884 EXPECT_TRUE(base::Version("1.0").Equals(ping_items[0].next_version)); 884 EXPECT_EQ(base::Version("1.0"), ping_items[0].next_version);
885 EXPECT_EQ(1, ping_items[0].error_category); // Network error. 885 EXPECT_EQ(1, ping_items[0].error_category); // Network error.
886 EXPECT_EQ(-118, ping_items[0].error_code); 886 EXPECT_EQ(-118, ping_items[0].error_code);
887 EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_items[1].id); 887 EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_items[1].id);
888 EXPECT_TRUE(base::Version("0.8").Equals(ping_items[1].previous_version)); 888 EXPECT_EQ(base::Version("0.8"), ping_items[1].previous_version);
889 EXPECT_TRUE(base::Version("1.0").Equals(ping_items[1].next_version)); 889 EXPECT_EQ(base::Version("1.0"), ping_items[1].next_version);
890 EXPECT_EQ(0, ping_items[1].error_category); 890 EXPECT_EQ(0, ping_items[1].error_category);
891 EXPECT_EQ(0, ping_items[1].error_code); 891 EXPECT_EQ(0, ping_items[1].error_code);
892 } 892 }
893 }; 893 };
894 894
895 scoped_ptr<FakePingManager> ping_manager(new FakePingManager(*config())); 895 scoped_ptr<FakePingManager> ping_manager(new FakePingManager(*config()));
896 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl( 896 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl(
897 config(), std::move(ping_manager), &FakeUpdateChecker::Create, 897 config(), std::move(ping_manager), &FakeUpdateChecker::Create,
898 &FakeCrxDownloader::Create)); 898 &FakeCrxDownloader::Create));
899 899
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 }; 1131 };
1132 1132
1133 class FakePingManager : public FakePingManagerImpl { 1133 class FakePingManager : public FakePingManagerImpl {
1134 public: 1134 public:
1135 explicit FakePingManager(const Configurator& config) 1135 explicit FakePingManager(const Configurator& config)
1136 : FakePingManagerImpl(config) {} 1136 : FakePingManagerImpl(config) {}
1137 ~FakePingManager() override { 1137 ~FakePingManager() override {
1138 const auto& ping_items = items(); 1138 const auto& ping_items = items();
1139 EXPECT_EQ(2U, ping_items.size()); 1139 EXPECT_EQ(2U, ping_items.size());
1140 EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_items[0].id); 1140 EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_items[0].id);
1141 EXPECT_TRUE(base::Version("0.8").Equals(ping_items[0].previous_version)); 1141 EXPECT_EQ(base::Version("0.8"), ping_items[0].previous_version);
1142 EXPECT_TRUE(base::Version("1.0").Equals(ping_items[0].next_version)); 1142 EXPECT_EQ(base::Version("1.0"), ping_items[0].next_version);
1143 EXPECT_EQ(0, ping_items[0].error_category); 1143 EXPECT_EQ(0, ping_items[0].error_category);
1144 EXPECT_EQ(0, ping_items[0].error_code); 1144 EXPECT_EQ(0, ping_items[0].error_code);
1145 EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_items[1].id); 1145 EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_items[1].id);
1146 EXPECT_TRUE(base::Version("1.0").Equals(ping_items[1].previous_version)); 1146 EXPECT_EQ(base::Version("1.0"), ping_items[1].previous_version);
1147 EXPECT_TRUE(base::Version("2.0").Equals(ping_items[1].next_version)); 1147 EXPECT_EQ(base::Version("2.0"), ping_items[1].next_version);
1148 EXPECT_EQ(0, ping_items[1].diff_error_category); 1148 EXPECT_EQ(0, ping_items[1].diff_error_category);
1149 EXPECT_EQ(0, ping_items[1].diff_error_code); 1149 EXPECT_EQ(0, ping_items[1].diff_error_code);
1150 } 1150 }
1151 }; 1151 };
1152 1152
1153 scoped_ptr<FakePingManager> ping_manager(new FakePingManager(*config())); 1153 scoped_ptr<FakePingManager> ping_manager(new FakePingManager(*config()));
1154 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl( 1154 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl(
1155 config(), std::move(ping_manager), &FakeUpdateChecker::Create, 1155 config(), std::move(ping_manager), &FakeUpdateChecker::Create,
1156 &FakeCrxDownloader::Create)); 1156 &FakeCrxDownloader::Create));
1157 1157
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
1348 }; 1348 };
1349 1349
1350 class FakePingManager : public FakePingManagerImpl { 1350 class FakePingManager : public FakePingManagerImpl {
1351 public: 1351 public:
1352 explicit FakePingManager(const Configurator& config) 1352 explicit FakePingManager(const Configurator& config)
1353 : FakePingManagerImpl(config) {} 1353 : FakePingManagerImpl(config) {}
1354 ~FakePingManager() override { 1354 ~FakePingManager() override {
1355 const auto& ping_items = items(); 1355 const auto& ping_items = items();
1356 EXPECT_EQ(1U, ping_items.size()); 1356 EXPECT_EQ(1U, ping_items.size());
1357 EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_items[0].id); 1357 EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_items[0].id);
1358 EXPECT_TRUE(base::Version("0.9").Equals(ping_items[0].previous_version)); 1358 EXPECT_EQ(base::Version("0.9"), ping_items[0].previous_version);
1359 EXPECT_TRUE(base::Version("1.0").Equals(ping_items[0].next_version)); 1359 EXPECT_EQ(base::Version("1.0"), ping_items[0].next_version);
1360 EXPECT_EQ(3, ping_items[0].error_category); // kInstallError. 1360 EXPECT_EQ(3, ping_items[0].error_category); // kInstallError.
1361 EXPECT_EQ(9, ping_items[0].error_code); // kInstallerError. 1361 EXPECT_EQ(9, ping_items[0].error_code); // kInstallerError.
1362 } 1362 }
1363 }; 1363 };
1364 1364
1365 scoped_ptr<PingManager> ping_manager(new FakePingManager(*config())); 1365 scoped_ptr<PingManager> ping_manager(new FakePingManager(*config()));
1366 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl( 1366 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl(
1367 config(), std::move(ping_manager), &FakeUpdateChecker::Create, 1367 config(), std::move(ping_manager), &FakeUpdateChecker::Create,
1368 &FakeCrxDownloader::Create)); 1368 &FakeCrxDownloader::Create));
1369 1369
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
1602 }; 1602 };
1603 1603
1604 class FakePingManager : public FakePingManagerImpl { 1604 class FakePingManager : public FakePingManagerImpl {
1605 public: 1605 public:
1606 explicit FakePingManager(const Configurator& config) 1606 explicit FakePingManager(const Configurator& config)
1607 : FakePingManagerImpl(config) {} 1607 : FakePingManagerImpl(config) {}
1608 ~FakePingManager() override { 1608 ~FakePingManager() override {
1609 const auto& ping_items = items(); 1609 const auto& ping_items = items();
1610 EXPECT_EQ(2U, ping_items.size()); 1610 EXPECT_EQ(2U, ping_items.size());
1611 EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_items[0].id); 1611 EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_items[0].id);
1612 EXPECT_TRUE(base::Version("0.8").Equals(ping_items[0].previous_version)); 1612 EXPECT_EQ(base::Version("0.8"), ping_items[0].previous_version);
1613 EXPECT_TRUE(base::Version("1.0").Equals(ping_items[0].next_version)); 1613 EXPECT_EQ(base::Version("1.0"), ping_items[0].next_version);
1614 EXPECT_EQ(0, ping_items[0].error_category); 1614 EXPECT_EQ(0, ping_items[0].error_category);
1615 EXPECT_EQ(0, ping_items[0].error_code); 1615 EXPECT_EQ(0, ping_items[0].error_code);
1616 EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_items[1].id); 1616 EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_items[1].id);
1617 EXPECT_TRUE(base::Version("1.0").Equals(ping_items[1].previous_version)); 1617 EXPECT_EQ(base::Version("1.0"), ping_items[1].previous_version);
1618 EXPECT_TRUE(base::Version("2.0").Equals(ping_items[1].next_version)); 1618 EXPECT_EQ(base::Version("2.0"), ping_items[1].next_version);
1619 EXPECT_TRUE(ping_items[1].diff_update_failed); 1619 EXPECT_TRUE(ping_items[1].diff_update_failed);
1620 EXPECT_EQ(1, ping_items[1].diff_error_category); // kNetworkError. 1620 EXPECT_EQ(1, ping_items[1].diff_error_category); // kNetworkError.
1621 EXPECT_EQ(-1, ping_items[1].diff_error_code); 1621 EXPECT_EQ(-1, ping_items[1].diff_error_code);
1622 } 1622 }
1623 }; 1623 };
1624 1624
1625 scoped_ptr<FakePingManager> ping_manager(new FakePingManager(*config())); 1625 scoped_ptr<FakePingManager> ping_manager(new FakePingManager(*config()));
1626 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl( 1626 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl(
1627 config(), std::move(ping_manager), &FakeUpdateChecker::Create, 1627 config(), std::move(ping_manager), &FakeUpdateChecker::Create,
1628 &FakeCrxDownloader::Create)); 1628 &FakeCrxDownloader::Create));
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
1904 }; 1904 };
1905 1905
1906 class FakePingManager : public FakePingManagerImpl { 1906 class FakePingManager : public FakePingManagerImpl {
1907 public: 1907 public:
1908 explicit FakePingManager(const Configurator& config) 1908 explicit FakePingManager(const Configurator& config)
1909 : FakePingManagerImpl(config) {} 1909 : FakePingManagerImpl(config) {}
1910 ~FakePingManager() override { 1910 ~FakePingManager() override {
1911 const auto& ping_items = items(); 1911 const auto& ping_items = items();
1912 EXPECT_EQ(1U, ping_items.size()); 1912 EXPECT_EQ(1U, ping_items.size());
1913 EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_items[0].id); 1913 EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_items[0].id);
1914 EXPECT_TRUE(base::Version("0.0").Equals(ping_items[0].previous_version)); 1914 EXPECT_EQ(base::Version("0.0"), ping_items[0].previous_version);
1915 EXPECT_TRUE(base::Version("1.0").Equals(ping_items[0].next_version)); 1915 EXPECT_EQ(base::Version("1.0"), ping_items[0].next_version);
1916 EXPECT_EQ(0, ping_items[0].error_category); 1916 EXPECT_EQ(0, ping_items[0].error_category);
1917 EXPECT_EQ(0, ping_items[0].error_code); 1917 EXPECT_EQ(0, ping_items[0].error_code);
1918 } 1918 }
1919 }; 1919 };
1920 1920
1921 scoped_ptr<FakePingManager> ping_manager(new FakePingManager(*config())); 1921 scoped_ptr<FakePingManager> ping_manager(new FakePingManager(*config()));
1922 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl( 1922 scoped_refptr<UpdateClient> update_client(new UpdateClientImpl(
1923 config(), std::move(ping_manager), &FakeUpdateChecker::Create, 1923 config(), std::move(ping_manager), &FakeUpdateChecker::Create,
1924 &FakeCrxDownloader::Create)); 1924 &FakeCrxDownloader::Create));
1925 1925
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
2118 2118
2119 std::vector<std::string> empty_id_list; 2119 std::vector<std::string> empty_id_list;
2120 base::RunLoop runloop; 2120 base::RunLoop runloop;
2121 update_client->Update( 2121 update_client->Update(
2122 empty_id_list, base::Bind(&DataCallbackFake::Callback), 2122 empty_id_list, base::Bind(&DataCallbackFake::Callback),
2123 base::Bind(&CompletionCallbackFake::Callback, runloop.QuitClosure())); 2123 base::Bind(&CompletionCallbackFake::Callback, runloop.QuitClosure()));
2124 runloop.Run(); 2124 runloop.Run();
2125 } 2125 }
2126 2126
2127 } // namespace update_client 2127 } // namespace update_client
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698