Comparison and streaming operators for base::Version

base/version.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/version.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 16 matching lines @@
   std::vector<StringPiece> numbers =
       SplitStringPiece(version_str, ".", KEEP_WHITESPACE, SPLIT_WANT_ALL);
   if (numbers.empty())
     return false;
 
   for (auto it = numbers.begin(); it != numbers.end(); ++it) {
     if (StartsWith(*it, "+", CompareCase::SENSITIVE))
       return false;
 
     // TODO(brettw) when we have a StringPiece version of StringToUint, delete
     // this string conversion.

[Rob Percival, 2016/01/09 23:54:03]

What does the above TODO mean?

[brettw, 2016/01/19 23:33:32]

Look like it's obsolete and we can delete the TODO.

     unsigned int num;
     if (!StringToUint(*it, &num))
       return false;
 
     // This throws out leading zeros for the first item only.
     if (it == numbers.begin() && UintToString(num) != *it)
       return false;
 
     // StringToUint returns unsigned int but Version fields are uint32_t.
     static_assert(sizeof (uint32_t) == sizeof (unsigned int),
@@ skipping 96 matching lines @@
   // components is greater (e.g. 3.2.3 vs 1.*).
   DCHECK_GT(parsed.size(), 0UL);
   const size_t min_num_comp = std::min(components_.size(), parsed.size());
   for (size_t i = 0; i < min_num_comp; ++i) {
     if (components_[i] != parsed[i])
       return 1;
   }
   return 0;
 }
 
-bool Version::Equals(const Version& that) const {
-  DCHECK(IsValid());
-  DCHECK(that.IsValid());
-  return (CompareTo(that) == 0);
-}
-
 int Version::CompareTo(const Version& other) const {
   DCHECK(IsValid());
   DCHECK(other.IsValid());
   return CompareVersionComponents(components_, other.components_);
 }
 
 const std::string Version::GetString() const {
   DCHECK(IsValid());
   std::string version_str;
   size_t count = components_.size();
   for (size_t i = 0; i < count - 1; ++i) {
     version_str.append(UintToString(components_[i]));
     version_str.append(".");
   }
   version_str.append(UintToString(components_[count - 1]));
   return version_str;
 }
 
+bool operator==(const Version& v1, const Version& v2) {
+  return v1.CompareTo(v2) == 0;
+}
+
+bool operator!=(const Version& v1, const Version& v2) {
+  return !(v1 == v2);
+}
+
+bool operator<(const Version& v1, const Version& v2) {
+  return v1.CompareTo(v2) < 0;
+}
+
+bool operator<=(const Version& v1, const Version& v2) {
+  return v1.CompareTo(v2) <= 0;
+}
+
+bool operator>(const Version& v1, const Version& v2) {
+  return v1.CompareTo(v2) > 0;
+}
+
+bool operator>=(const Version& v1, const Version& v2) {
+  return v1.CompareTo(v2) >= 0;
+}
+
+std::ostream& operator<<(std::ostream& stream, const Version& v) {
+  return stream << v.GetString();
+}
+
 }  // namespace base