more general GM setup for testing image filtering -- now with checkerboards, images, and text.

more general GM setup for testing image filtering -- now with checkerboards, images, and text.

include image bytes for lena bitmap, tool for generating image byte arrays from image files


BUG=

Committed: https://code.google.com/p/skia/source/detail?r=9361

[reed1, 2013-05-29 19:26:04]

https://codereview.chromium.org/15755019/diff/1/gm/filterbitmap.cpp
File gm/filterbitmap.cpp (right):

https://codereview.chromium.org/15755019/diff/1/gm/filterbitmap.cpp#newcode74
gm/filterbitmap.cpp:74: fName = SkString(name);
alternative (slightly more efficient) : fName.set(name);

https://codereview.chromium.org/15755019/diff/1/gm/lena_bytes.h
File gm/lena_bytes.h (right):

https://codereview.chromium.org/15755019/diff/1/gm/lena_bytes.h#newcode1
gm/lena_bytes.h:1: unsigned char lena_128[] = {
What is this array?
Should it be static const? If so, it should be named gLena_128 or something.
How was it generated? That should be documented or (better) supply a function
that can reproduce it.

[robertphillips, 2013-05-29 20:55:01]

I think we may want to use something like mandrill rather than Lena.

[humper, 2013-05-29 21:03:38]

On 2013/05/29 20:55:01, robertphillips wrote:
> I think we may want to use something like mandrill rather than Lena.

Heh whoops, just saw this message as I checked in a new verseion with lena pngs.
 Will switch it over, one sec.

[humper, 2013-05-29 21:06:42]

On 2013/05/29 21:03:38, humper wrote:
> On 2013/05/29 20:55:01, robertphillips wrote:
> > I think we may want to use something like mandrill rather than Lena.
> 
> Heh whoops, just saw this message as I checked in a new verseion with lena
pngs.
>  Will switch it over, one sec.

Okay, new images uploaded.

When you run this GM, make sure to use the --resourcePath parameter:

gm --match filterbitmap --resourcePath /blah/blah/skia/trunk/resources

If it can't find the images, it will substitute a 1x1 red bitmap on failure.

[reed1, 2013-05-30 19:14:07]

lgtm

[humper, 2013-05-31 12:50:54]

Committed patchset #3 manually as r9361 (presubmit successful).