Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tools/testing/legpad/legpad.py

Issue 15755017: Switch from DRT to content shell. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/legpad/legpad.py
diff --git a/tools/testing/legpad/legpad.py b/tools/testing/legpad/legpad.py
index 1a4aa558a5736b6c43b3dab9302782866292791a..fb43371b827af758c36e306c697b5b4de3a035ef 100644
--- a/tools/testing/legpad/legpad.py
+++ b/tools/testing/legpad/legpad.py
@@ -9,7 +9,7 @@ Legpad is used to compile .dart files to javascript, using the dart2js compiler.
This is accomplished by creating an html file (usually called
<something>.legpad.html) that executes the dart2js compiler when the page
-is loaded by a web browser (or DumpRenderTree).
+is loaded by a web browser (or content shell).
The <something>.legpad.html file contains:
@@ -24,7 +24,7 @@ When the html page is loaded by a browser, the leg compiler is invoked
and the dart program is compiled to javascript. The generated javascript is
placed in a <pre> element with id "output".
-When the html page is passed to DumpRenderTree, the dumped output will
+When the html page is passed to content shell, the dumped output will
have the generated javascript.
See 'example.sh' for an example of how to run legpad.
@@ -181,7 +181,7 @@ class Pad(object):
logging.debug("js_file: '%s" % self.js_file)
- # this is the html file that we pass to DumpRenderTree
+ # this is the html file that we pass to content shell.
self.html_file = self.main_file + ".legpad.html"
logging.debug("html_file: '%s'" % self.html_file)
@@ -222,9 +222,9 @@ class Pad(object):
return html
def generate_js(self):
- drt = os.path.join(self.dart_dir, "client/tests/drt/DumpRenderTree")
+ drt = os.path.join(self.dart_dir, "client/tests/drt/content_shell")
if platform.system() == 'Darwin':
- drt += ".app"
+ drt = os.path.join(self.dart_dir, "client/tests/drt/Content Shell.app")
elif platform.system() == 'Windows':
raise Exception("legpad does not run on Windows")
@@ -236,7 +236,7 @@ class Pad(object):
stdout = run_command(args)
match = OUTPUT_JAVASCRIPT_REGEX.match(stdout)
if not match:
- raise Exception("can't find regex in DumpRenderTree output")
+ raise Exception("can't find regex in content shell output")
return match.group(1)
@staticmethod

Powered by Google App Engine
This is Rietveld 408576698