Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: win8/test/metro_registration_helper.h

Issue 15755016: Introduce a single call to grab default browser on Win8 for tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: win8/test/metro_registration_helper.h
diff --git a/win8/test/metro_registration_helper.h b/win8/test/metro_registration_helper.h
index 86f00159f84d9b789cf225afbb87e99105cd5c75..b4e43e4acc824a5276539b357a45f094f66dd5ca 100644
--- a/win8/test/metro_registration_helper.h
+++ b/win8/test/metro_registration_helper.h
@@ -9,18 +9,14 @@
namespace win8 {
-// Registers a viewer process as a potential Win8 default browser. Intended to
-// be used by a test binary in the build output directory and assumes the
-// presence of test_registrar.exe, a viewer process and all needed DLLs in the
-// same directory as the calling module. The viewer process is then subsequently
-// set as THE default Win8 browser, is activatable using the AppUserModelId in
-// |app_user_model_id| and will show up in the default browser selection dialog
-// as |viewer_process_name|.
-//
-// See also open_with_dialog_controller.h for a mechanism for setting THE
-// default Win8 browser.
-bool RegisterTestDefaultBrowser(const string16& app_user_model_id,
- const string16& viewer_process_name);
+// Synchronously makes chrome.exe THE default Win8 browser after which it is
+// activatable into a Metro viewer process using
+// win8::test::kDefaultTestAppUserModelId. Intended to be used by a test binary
+// in the output directory and assumes the presence of test_registrar.exe,
+// chrome.exe (the viewer process) and all needed DLLs in the same directory
grt (UTC plus 2) 2013/05/27 16:11:14 nit: comma before " and"
gab 2013/05/27 16:47:58 Done.
+// as the calling module.
+// NOTE: COM should be initialized prior to calling this method.
grt (UTC plus 2) 2013/05/27 16:11:14 should be or must be? the latter, i think.
gab 2013/05/27 16:47:58 "must" indeed :)
+bool MakeTestDefaultBrowserSynchronously();
} // namespace win8

Powered by Google App Engine
This is Rietveld 408576698