Issue 15755008: Timeline: fix switching from Events to Frame mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15755008: Timeline: fix switching from Events to Frame mode (Closed)

Created:
7 years, 7 months ago by caseq

Modified:
7 years, 7 months ago

Reviewers:
pfeldman, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Timeline: fix switching from Events to Frame mode We create frame controller after a call to repopulateRecords(), so it may batch-pull all records from model. If repopulateRecords() calls refresh synchronously, refresh() does not have frame controller and does not render frame bars. BUG=234297 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151057

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/devtools/front_end/TimelinePanel.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

caseq

7 years, 7 months ago (2013-05-24 08:33:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r151057 (presubmit successful).

Expand Messages | Collapse Messages