Change output of string equality match failures.

pkg/unittest/lib/src/basematcher.dart

Index: pkg/unittest/lib/src/basematcher.dart
===================================================================
--- pkg/unittest/lib/src/basematcher.dart	(revision 23039)
+++ pkg/unittest/lib/src/basematcher.dart	(working copy)
@@ -31,6 +31,14 @@
   const BaseMatcher();
 
   /**
+   * Whether failures should include the actual value in the output.
+   * The reason is passed in so that it can be inspected if necessary
+   * for some more complex cases.
+   */
+  bool includeActual(reason) => !reason.toString().startsWith('was ');

[Siggi Cherem (dart-lang), 2013/05/23 00:43:47]

2 comments:
a) how about storing a boolean property in your matcher instead? In the end it
is the same instance of this class that will print the mismatch.


b) rename to phrase it as a question or a statement. Ideas:
 - "includesActual" (see the extra 's'), which would mean the opposite of what
your method currently does.
 - "shouldIncludeActual"

I prefer the former, since it better represents a property of this object.

+
+
+  /**
    * Tests the matcher against a given [item]
    * and return true if the match succeeds; false otherwise.
    * [matchState] may be used to return additional info for