Regenerate Dart .mojom files

Regenerate Dart .mojom files

Some of the .mojom files generate their code in a different order with
the new compiler.

BUG=
R=rudominer@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/348be1b425be307ee63179a0a8693cfc6a850661

[alexfandrianto, 2016-01-08 20:24:09]

alexfandrianto@google.com changed reviewers:
+ rudominer@chromium.org

[alexfandrianto, 2016-01-08 20:24:09]

https://codereview.chromium.org/1575433005/diff/1/mojo/dart/packages/_mojo_fo...
File
mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart
(right):

https://codereview.chromium.org/1575433005/diff/1/mojo/dart/packages/_mojo_fo...
mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart:1093:
int get version => 1;
Is the version change a mistake? The corresponding mojom file is here and hasn't
changed for over a month.

https://github.com/domokit/mojo/blob/master/mojo/public/interfaces/bindings/t...

[tonyg, 2016-01-08 20:28:37]

Description was changed from

==========
Regenerate Dart .mojom files

Some of the .mojom files generate their code in a different order with
the new compiler.

BUG=
==========

to

==========
Regenerate Dart .mojom files

Some of the .mojom files generate their code in a different order with
the new compiler.

BUG=
==========

[rudominer, 2016-01-08 20:29:40]

When I run ./mojo/dart/tools/bindings/generate.py in a clean client it produces
no new .mojom files.

Can you explain why you are doing this patch?

[tonyg, 2016-01-08 20:29:40]

tonyg@chromium.org changed reviewers:
+ tonyg@chromium.org

[tonyg, 2016-01-08 20:29:41]

drive-by: I thought that a presubmit check was supposed to ensure these were
updated. Do we know why that didn't seem to work here?

[rudominer, 2016-01-08 20:49:04]

rudominer@chromium.org changed reviewers:
+ johnmccutchan@chromium.org, zanderoso@chromium.org

[rudominer, 2016-01-08 20:49:41]

rudominer@chromium.org changed reviewers:
+ johnmccutchan@google.com
- johnmccutchan@chromium.org

[rudominer, 2016-01-08 20:51:20]

On 2016/01/08 20:49:41, rudominer wrote:

Sorry, my previous message got lost:

I don't want to "L"-"G" this because I don't understand the whole
checking-in-the-.mojom.dart-file thing and I can't explain why these
files have changed.

Maybe John or Zach could explain it to us.

[rudominer, 2016-01-08 21:06:10]

lgtm

[alexfandrianto, 2016-01-08 21:21:49]

On 2016/01/08 21:06:10, rudominer wrote:
> lgtm

I ran it with -f and the dart_to_cpp changed again. It seems to swap the way it
orders its switch statements a lot. (Go map ordering?)

But I'll wait for the tests to pass before submitting.

[alexfandrianto, 2016-01-08 23:30:52]

On 2016/01/08 21:21:49, alexfandrianto wrote:
> On 2016/01/08 21:06:10, rudominer wrote:
> > lgtm
> 
> I ran it with -f and the dart_to_cpp changed again. It seems to swap the way
it
> orders its switch statements a lot. (Go map ordering?)
> 
> But I'll wait for the tests to pass before submitting.

It looks like I cannot submit. The Mojo Android tests are failing, but I don't
see why this CL would cause failures.

[rudominer, 2016-01-08 23:33:31]

On 2016/01/08 23:30:52, alexfandrianto wrote:
> On 2016/01/08 21:21:49, alexfandrianto wrote:
> > On 2016/01/08 21:06:10, rudominer wrote:
> > > lgtm
> > 
> > I ran it with -f and the dart_to_cpp changed again. It seems to swap the way
> it
> > orders its switch statements a lot. (Go map ordering?)
> > 
> > But I'll wait for the tests to pass before submitting.
> 
> It looks like I cannot submit. The Mojo Android tests are failing, but I don't
> see why this CL would cause failures.

Unfortunately these tests have been broken for weeks and everybody seems to be
ignoring it. 
You can see that they are purple on the waterfall.
https://build.chromium.org/p/client.mojo/waterfall

You can submit if these are the only broken tests.

[alexfandrianto, 2016-01-08 23:42:47]

On 2016/01/08 23:33:31, rudominer wrote:
> On 2016/01/08 23:30:52, alexfandrianto wrote:
> > On 2016/01/08 21:21:49, alexfandrianto wrote:
> > > On 2016/01/08 21:06:10, rudominer wrote:
> > > > lgtm
> > > 
> > > I ran it with -f and the dart_to_cpp changed again. It seems to swap the
way
> > it
> > > orders its switch statements a lot. (Go map ordering?)
> > > 
> > > But I'll wait for the tests to pass before submitting.
> > 
> > It looks like I cannot submit. The Mojo Android tests are failing, but I
don't
> > see why this CL would cause failures.
> 
> Unfortunately these tests have been broken for weeks and everybody seems to be
> ignoring it. 
> You can see that they are purple on the waterfall.
> https://build.chromium.org/p/client.mojo/waterfall
> 
> You can submit if these are the only broken tests.

Oh, cool. Thanks

[alexfandrianto, 2016-01-08 23:43:06]

Description was changed from

==========
Regenerate Dart .mojom files

Some of the .mojom files generate their code in a different order with
the new compiler.

BUG=
==========

to

==========
Regenerate Dart .mojom files

Some of the .mojom files generate their code in a different order with
the new compiler.

BUG=
R=rudominer@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/348be1b425be307ee63179a0a86...
==========

[alexfandrianto, 2016-01-08 23:43:07]

Committed patchset #5 (id:80001) manually as
348be1b425be307ee63179a0a8693cfc6a850661 (presubmit successful).