Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 1575433002: Fix Win Clang -Wpessimizing-move error (Closed)

Created:
4 years, 11 months ago by hans
Modified:
4 years, 11 months ago
Reviewers:
erikchen
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Win Clang -Wpessimizing-move error The build was failing with: ..\..\ipc\attachment_broker_privileged_win_unittest.cc(105,10) : error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move] return std::move(shared_memory); ^ BUG=82385 TBR=erikchen Committed: https://chromium.googlesource.com/chromium/src/+/b7da247515b4c2f0fc8d6474f891f50335a0cc90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ipc/attachment_broker_privileged_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575433002/1
4 years, 11 months ago (2016-01-08 14:23:44 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b7da247515b4c2f0fc8d6474f891f50335a0cc90 Cr-Commit-Position: refs/heads/master@{#368328}
4 years, 11 months ago (2016-01-08 14:36:00 UTC) #6
hans
4 years, 11 months ago (2016-01-08 14:36:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7da247515b4c2f0fc8d6474f891f50335a0cc90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698