| Index: src/ia32/lithium-codegen-ia32.cc
|
| diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc
|
| index 1a20fc3b6815c1d2c69a0dfdfb2a209e1f2098e4..54624e7b19513bbdf57ddeca4e8b36987ae3fa91 100644
|
| --- a/src/ia32/lithium-codegen-ia32.cc
|
| +++ b/src/ia32/lithium-codegen-ia32.cc
|
| @@ -175,18 +175,28 @@ bool LCodeGen::GeneratePrologue() {
|
| }
|
| #endif
|
|
|
| - // Strict mode functions and builtins need to replace the receiver
|
| - // with undefined when called as functions (without an explicit
|
| - // receiver object). ecx is zero for method calls and non-zero for
|
| - // function calls.
|
| - if (!info_->is_classic_mode() || info_->is_native()) {
|
| + // Classic mode functions and builtins need to replace the receiver with the
|
| + // global proxy when called as functions (without an explicit receiver
|
| + // object).
|
| + if (info_->this_has_uses() &&
|
| + info_->is_classic_mode() &&
|
| + !info_->is_native()) {
|
| Label ok;
|
| - __ test(ecx, Operand(ecx));
|
| + __ test(ecx, ecx);
|
| __ j(zero, &ok, Label::kNear);
|
| +
|
| // +1 for return address.
|
| int receiver_offset = (scope()->num_parameters() + 1) * kPointerSize;
|
| - __ mov(Operand(esp, receiver_offset),
|
| - Immediate(isolate()->factory()->undefined_value()));
|
| + __ mov(ecx, Operand(esp, receiver_offset));
|
| +
|
| + __ cmp(ecx, isolate()->factory()->undefined_value());
|
| + __ j(not_equal, &ok, Label::kNear);
|
| +
|
| + __ mov(ecx, GlobalObjectOperand());
|
| + __ mov(ecx, FieldOperand(ecx, GlobalObject::kGlobalReceiverOffset));
|
| +
|
| + __ mov(Operand(esp, receiver_offset), ecx);
|
| +
|
| __ bind(&ok);
|
| }
|
|
|
| @@ -1615,10 +1625,10 @@ void LCodeGen::DoMathFloorOfDiv(LMathFloorOfDiv* instr) {
|
| double multiplier_f =
|
| static_cast<double>(static_cast<uint64_t>(1) << shift) / divisor_abs;
|
| int64_t multiplier;
|
| - if (multiplier_f - floor(multiplier_f) < 0.5) {
|
| - multiplier = static_cast<int64_t>(floor(multiplier_f));
|
| + if (multiplier_f - std::floor(multiplier_f) < 0.5) {
|
| + multiplier = static_cast<int64_t>(std::floor(multiplier_f));
|
| } else {
|
| - multiplier = static_cast<int64_t>(floor(multiplier_f)) + 1;
|
| + multiplier = static_cast<int64_t>(std::floor(multiplier_f)) + 1;
|
| }
|
| // The multiplier is a uint32.
|
| ASSERT(multiplier > 0 &&
|
| @@ -3164,10 +3174,9 @@ void LCodeGen::DoLoadGlobalGeneric(LLoadGlobalGeneric* instr) {
|
| ASSERT(ToRegister(instr->result()).is(eax));
|
|
|
| __ mov(ecx, instr->name());
|
| - RelocInfo::Mode mode = instr->for_typeof() ? RelocInfo::CODE_TARGET :
|
| - RelocInfo::CODE_TARGET_CONTEXT;
|
| - Handle<Code> ic = isolate()->builtins()->LoadIC_Initialize();
|
| - CallCode(ic, mode, instr);
|
| + ContextualMode mode = instr->for_typeof() ? NOT_CONTEXTUAL : CONTEXTUAL;
|
| + Handle<Code> ic = LoadIC::initialize_stub(isolate(), mode);
|
| + CallCode(ic, RelocInfo::CODE_TARGET, instr);
|
| }
|
|
|
|
|
| @@ -3196,10 +3205,10 @@ void LCodeGen::DoStoreGlobalGeneric(LStoreGlobalGeneric* instr) {
|
| ASSERT(ToRegister(instr->value()).is(eax));
|
|
|
| __ mov(ecx, instr->name());
|
| - Handle<Code> ic = (instr->strict_mode_flag() == kStrictMode)
|
| - ? isolate()->builtins()->StoreIC_Initialize_Strict()
|
| - : isolate()->builtins()->StoreIC_Initialize();
|
| - CallCode(ic, RelocInfo::CODE_TARGET_CONTEXT, instr);
|
| + Handle<Code> ic = StoreIC::initialize_stub(isolate(),
|
| + instr->strict_mode_flag(),
|
| + CONTEXTUAL);
|
| + CallCode(ic, RelocInfo::CODE_TARGET, instr);
|
| }
|
|
|
|
|
| @@ -3318,7 +3327,7 @@ void LCodeGen::DoLoadNamedGeneric(LLoadNamedGeneric* instr) {
|
| ASSERT(ToRegister(instr->result()).is(eax));
|
|
|
| __ mov(ecx, instr->name());
|
| - Handle<Code> ic = isolate()->builtins()->LoadIC_Initialize();
|
| + Handle<Code> ic = LoadIC::initialize_stub(isolate(), NOT_CONTEXTUAL);
|
| CallCode(ic, RelocInfo::CODE_TARGET, instr);
|
| }
|
|
|
| @@ -3642,7 +3651,7 @@ void LCodeGen::DoWrapReceiver(LWrapReceiver* instr) {
|
| // If the receiver is null or undefined, we have to pass the global
|
| // object as a receiver to normal functions. Values have to be
|
| // passed unchanged to builtins and strict-mode functions.
|
| - Label global_object, receiver_ok;
|
| + Label receiver_ok, global_object;
|
| Label::Distance dist = DeoptEveryNTimes() ? Label::kFar : Label::kNear;
|
|
|
| // Do not transform the receiver to object for strict mode
|
| @@ -3672,13 +3681,11 @@ void LCodeGen::DoWrapReceiver(LWrapReceiver* instr) {
|
| __ jmp(&receiver_ok, Label::kNear);
|
|
|
| __ bind(&global_object);
|
| - // TODO(kmillikin): We have a hydrogen value for the global object. See
|
| - // if it's better to use it than to explicitly fetch it from the context
|
| - // here.
|
| - __ mov(receiver, Operand(ebp, StandardFrameConstants::kContextOffset));
|
| - __ mov(receiver, ContextOperand(receiver, Context::GLOBAL_OBJECT_INDEX));
|
| + __ mov(receiver, FieldOperand(function, JSFunction::kContextOffset));
|
| __ mov(receiver,
|
| - FieldOperand(receiver, JSGlobalObject::kGlobalReceiverOffset));
|
| + Operand(receiver, Context::SlotOffset(Context::GLOBAL_OBJECT_INDEX)));
|
| + __ mov(receiver, FieldOperand(receiver, GlobalObject::kGlobalReceiverOffset));
|
| +
|
| __ bind(&receiver_ok);
|
| }
|
|
|
| @@ -3720,7 +3727,7 @@ void LCodeGen::DoApplyArguments(LApplyArguments* instr) {
|
| this, pointers, Safepoint::kLazyDeopt);
|
| ParameterCount actual(eax);
|
| __ InvokeFunction(function, actual, CALL_FUNCTION,
|
| - safepoint_generator, CALL_AS_METHOD);
|
| + safepoint_generator, CALL_AS_FUNCTION);
|
| }
|
|
|
|
|
| @@ -3841,7 +3848,7 @@ void LCodeGen::DoCallConstantFunction(LCallConstantFunction* instr) {
|
| instr->hydrogen()->formal_parameter_count(),
|
| instr->arity(),
|
| instr,
|
| - CALL_AS_METHOD,
|
| + CALL_AS_FUNCTION,
|
| EDI_UNINITIALIZED);
|
| }
|
|
|
| @@ -4202,13 +4209,13 @@ void LCodeGen::DoInvokeFunction(LInvokeFunction* instr) {
|
| SafepointGenerator generator(
|
| this, pointers, Safepoint::kLazyDeopt);
|
| ParameterCount count(instr->arity());
|
| - __ InvokeFunction(edi, count, CALL_FUNCTION, generator, CALL_AS_METHOD);
|
| + __ InvokeFunction(edi, count, CALL_FUNCTION, generator, CALL_AS_FUNCTION);
|
| } else {
|
| CallKnownFunction(known_function,
|
| instr->hydrogen()->formal_parameter_count(),
|
| instr->arity(),
|
| instr,
|
| - CALL_AS_METHOD,
|
| + CALL_AS_FUNCTION,
|
| EDI_CONTAINS_TARGET);
|
| }
|
| }
|
| @@ -4231,11 +4238,10 @@ void LCodeGen::DoCallNamed(LCallNamed* instr) {
|
| ASSERT(ToRegister(instr->result()).is(eax));
|
|
|
| int arity = instr->arity();
|
| - RelocInfo::Mode mode = RelocInfo::CODE_TARGET;
|
| Handle<Code> ic =
|
| - isolate()->stub_cache()->ComputeCallInitialize(arity, mode);
|
| + isolate()->stub_cache()->ComputeCallInitialize(arity, NOT_CONTEXTUAL);
|
| __ mov(ecx, instr->name());
|
| - CallCode(ic, mode, instr);
|
| + CallCode(ic, RelocInfo::CODE_TARGET, instr);
|
| }
|
|
|
|
|
| @@ -4260,11 +4266,10 @@ void LCodeGen::DoCallGlobal(LCallGlobal* instr) {
|
| ASSERT(ToRegister(instr->result()).is(eax));
|
|
|
| int arity = instr->arity();
|
| - RelocInfo::Mode mode = RelocInfo::CODE_TARGET_CONTEXT;
|
| Handle<Code> ic =
|
| - isolate()->stub_cache()->ComputeCallInitialize(arity, mode);
|
| + isolate()->stub_cache()->ComputeCallInitialize(arity, CONTEXTUAL);
|
| __ mov(ecx, instr->name());
|
| - CallCode(ic, mode, instr);
|
| + CallCode(ic, RelocInfo::CODE_TARGET, instr);
|
| }
|
|
|
|
|
| @@ -4305,10 +4310,9 @@ void LCodeGen::DoCallNewArray(LCallNewArray* instr) {
|
| (AllocationSite::GetMode(kind) == TRACK_ALLOCATION_SITE)
|
| ? DISABLE_ALLOCATION_SITES
|
| : DONT_OVERRIDE;
|
| - ContextCheckMode context_mode = CONTEXT_CHECK_NOT_REQUIRED;
|
|
|
| if (instr->arity() == 0) {
|
| - ArrayNoArgumentConstructorStub stub(kind, context_mode, override_mode);
|
| + ArrayNoArgumentConstructorStub stub(kind, override_mode);
|
| CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
|
| } else if (instr->arity() == 1) {
|
| Label done;
|
| @@ -4321,18 +4325,17 @@ void LCodeGen::DoCallNewArray(LCallNewArray* instr) {
|
| __ j(zero, &packed_case, Label::kNear);
|
|
|
| ElementsKind holey_kind = GetHoleyElementsKind(kind);
|
| - ArraySingleArgumentConstructorStub stub(holey_kind, context_mode,
|
| - override_mode);
|
| + ArraySingleArgumentConstructorStub stub(holey_kind, override_mode);
|
| CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
|
| __ jmp(&done, Label::kNear);
|
| __ bind(&packed_case);
|
| }
|
|
|
| - ArraySingleArgumentConstructorStub stub(kind, context_mode, override_mode);
|
| + ArraySingleArgumentConstructorStub stub(kind, override_mode);
|
| CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
|
| __ bind(&done);
|
| } else {
|
| - ArrayNArgumentsConstructorStub stub(kind, context_mode, override_mode);
|
| + ArrayNArgumentsConstructorStub stub(kind, override_mode);
|
| CallCode(stub.GetCode(isolate()), RelocInfo::CONSTRUCT_CALL, instr);
|
| }
|
| }
|
| @@ -4496,9 +4499,9 @@ void LCodeGen::DoStoreNamedGeneric(LStoreNamedGeneric* instr) {
|
| ASSERT(ToRegister(instr->value()).is(eax));
|
|
|
| __ mov(ecx, instr->name());
|
| - Handle<Code> ic = (instr->strict_mode_flag() == kStrictMode)
|
| - ? isolate()->builtins()->StoreIC_Initialize_Strict()
|
| - : isolate()->builtins()->StoreIC_Initialize();
|
| + Handle<Code> ic = StoreIC::initialize_stub(isolate(),
|
| + instr->strict_mode_flag(),
|
| + NOT_CONTEXTUAL);
|
| CallCode(ic, RelocInfo::CODE_TARGET, instr);
|
| }
|
|
|
|
|