Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1575423002: Move properties from JSObject to JSReceiver (Closed)

Created:
4 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move properties from JSObject to JSReceiver That will allow for adding private symbols to JSProxies in a follow-up change BUG=chromium:571365 R=neis@chromium.org,verwaest@chromium.org,rossberg@chromium.org LOG=n Committed: https://crrev.com/4143a667b87f43cb6ff614f328b358ee0d5695fc Cr-Commit-Position: refs/heads/master@{#33241}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -36 lines) Patch
M src/factory.cc View 1 chunk +1 line, -0 lines 2 comments Download
M src/objects.h View 5 chunks +19 lines, -16 lines 0 comments Download
M src/objects-inl.h View 5 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
4 years, 11 months ago (2016-01-12 14:49:26 UTC) #1
jochen (gone - plz use gerrit)
ptal https://codereview.chromium.org/1575423002/diff/1/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/1575423002/diff/1/src/factory.cc#newcode2028 src/factory.cc:2028: result->initialize_properties(); is there any other way to allocate ...
4 years, 11 months ago (2016-01-12 14:51:06 UTC) #2
Toon Verwaest
lgtm https://codereview.chromium.org/1575423002/diff/1/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/1575423002/diff/1/src/factory.cc#newcode2028 src/factory.cc:2028: result->initialize_properties(); On 2016/01/12 14:51:05, jochen wrote: > is ...
4 years, 11 months ago (2016-01-12 15:03:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575423002/1
4 years, 11 months ago (2016-01-12 15:42:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 15:43:45 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 15:44:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4143a667b87f43cb6ff614f328b358ee0d5695fc
Cr-Commit-Position: refs/heads/master@{#33241}

Powered by Google App Engine
This is Rietveld 408576698