Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 15754005: Fix dependency: make file_system_util not depend on FileSystemURL (Closed)

Created:
7 years, 7 months ago by kinuko
Modified:
7 years, 7 months ago
Reviewers:
tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, nhiroki, calvinlo
Visibility:
Public.

Description

Fix dependency: make file_system_util not depend on FileSystemURL Move fileapi::AreSameFileSystem utility method to FileSystemURL. BUG=239710 TEST=FileSystemURLTest.IsInSameFileSystem R=tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -43 lines) Patch
M webkit/browser/fileapi/cross_operation_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/local_file_system_operation.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_url.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_url.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_url_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_util.h View 2 chunks +0 lines, -8 lines 0 comments Download
M webkit/fileapi/file_system_util.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M webkit/fileapi/file_system_util_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kinuko
Yet another small dependency fix. PTL
7 years, 7 months ago (2013-05-27 03:58:50 UTC) #1
tzik
lgtm
7 years, 7 months ago (2013-05-27 05:03:04 UTC) #2
kinuko
7 years, 7 months ago (2013-05-27 06:01:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r202373 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698