Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 15754004: Fix various MediaSource related crashes on Android. (Closed)

Created:
7 years, 7 months ago by acolwell GONE FROM CHROMIUM
Modified:
7 years, 7 months ago
Reviewers:
qinmin
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix various MediaSource related crashes on Android. This change fixes several issues that were causing crashes. - MediaPlayerHostMsg_DemuxerReady_Params was not initializing the xxx_codec member variables so audio-only or video-only content would randomly be flagged as A/V content with a random codec ID. - ChunkDemuxer::Stop() was not being called which could cause the delegate to be accessed after it was destroyed. - MediaSourceDelegate was signalling that it had metadata before the ChunkDemuxer was even initialized. This caused the HTMLMediaElement to signal that the load completed way too early and caused play() to be called when the delegate wasn't ready. BUG=233420 TEST=webkitmediasource-play.html LayoutTest reliably runs w/o crashing now. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201791

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address CR comments #

Patch Set 3 : Fix compiler error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -15 lines) Patch
M media/base/android/demuxer_stream_player_params.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/base/android/media_source_player.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/media/android/media_source_delegate.h View 1 2 5 chunks +19 lines, -4 lines 0 comments Download
M webkit/media/android/media_source_delegate.cc View 12 chunks +49 lines, -2 lines 0 comments Download
M webkit/media/android/webmediaplayer_android.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/media/android/webmediaplayer_android.cc View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
acolwell GONE FROM CHROMIUM
7 years, 7 months ago (2013-05-22 18:31:31 UTC) #1
qinmin
lgtm%nits https://codereview.chromium.org/15754004/diff/1/media/base/android/media_source_player.cc File media/base/android/media_source_player.cc (left): https://codereview.chromium.org/15754004/diff/1/media/base/android/media_source_player.cc#oldcode211 media/base/android/media_source_player.cc:211: OnMediaMetadataChanged(duration_, width_, height_, false); thanks for doing this, ...
7 years, 7 months ago (2013-05-22 18:51:24 UTC) #2
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/15754004/diff/1/webkit/media/android/media_source_delegate.cc File webkit/media/android/media_source_delegate.cc (right): https://codereview.chromium.org/15754004/diff/1/webkit/media/android/media_source_delegate.cc#newcode108 webkit/media/android/media_source_delegate.cc:108: chunk_demuxer_->Stop( On 2013/05/22 18:51:24, qinmin wrote: > Could there ...
7 years, 7 months ago (2013-05-22 19:12:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/15754004/5001
7 years, 7 months ago (2013-05-22 19:13:05 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-22 21:07:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/15754004/26002
7 years, 7 months ago (2013-05-22 21:11:36 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-23 14:27:20 UTC) #7
Message was sent while issue was closed.
Change committed as 201791

Powered by Google App Engine
This is Rietveld 408576698