Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 1575393002: Enhance chromium_tests.configure_build for generalized trybot mirroring (Closed)

Created:
4 years, 11 months ago by Paweł Hajdan Jr.
Modified:
4 years, 11 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Enhance chromium_tests.configure_build for generalized trybot mirroring BUG=573337 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298235

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -11 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 4 chunks +14 lines, -10 lines 3 comments Download
M scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py View 1 chunk +35 lines, -0 lines 2 comments Download
M scripts/slave/recipe_modules/goma/api.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Paweł Hajdan Jr.
4 years, 11 months ago (2016-01-12 12:24:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575393002/1
4 years, 11 months ago (2016-01-12 12:40:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-12 12:43:42 UTC) #6
Sergiy Byelozyorov
lgtm w/ comment https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_modules/chromium_tests/api.py File scripts/slave/recipe_modules/chromium_tests/api.py (right): https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_modules/chromium_tests/api.py#newcode143 scripts/slave/recipe_modules/chromium_tests/api.py:143: self.builders, Where is this populated? Is ...
4 years, 11 months ago (2016-01-12 15:03:56 UTC) #7
Paweł Hajdan Jr.
https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_modules/chromium_tests/api.py File scripts/slave/recipe_modules/chromium_tests/api.py (right): https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_modules/chromium_tests/api.py#newcode143 scripts/slave/recipe_modules/chromium_tests/api.py:143: self.builders, On 2016/01/12 at 15:03:56, Sergiy Byelozyorov wrote: > ...
4 years, 11 months ago (2016-01-12 15:05:39 UTC) #8
Sergiy Byelozyorov
LGTM https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_modules/chromium_tests/api.py File scripts/slave/recipe_modules/chromium_tests/api.py (right): https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_modules/chromium_tests/api.py#newcode143 scripts/slave/recipe_modules/chromium_tests/api.py:143: self.builders, On 2016/01/12 15:05:38, Paweł Hajdan Jr. wrote: ...
4 years, 11 months ago (2016-01-12 15:10:28 UTC) #9
Ken Russell (switch to Gerrit)
lgtm with comment https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py File scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py (right): https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py#newcode30 scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py:30: return self._consistent_get(self._get, name, default) This will ...
4 years, 11 months ago (2016-01-12 18:06:21 UTC) #10
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py File scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py (right): https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py#newcode30 scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py:30: return self._consistent_get(self._get, name, default) On 2016/01/12 18:06:21, Ken Russell ...
4 years, 11 months ago (2016-01-12 18:20:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575393002/1
4 years, 11 months ago (2016-01-13 07:15:38 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 07:18:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298235

Powered by Google App Engine
This is Rietveld 408576698