Enhance chromium_tests.configure_build for generalized trybot mirroring

Enhance chromium_tests.configure_build for generalized trybot mirroring

BUG=573337
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298235

[Paweł Hajdan Jr., 2016-01-12 12:24:47]

phajdan.jr@chromium.org changed reviewers:
+ kbr@chromium.org, sergiyb@chromium.org, tandrii@chromium.org

[Paweł Hajdan Jr., 2016-01-12 12:40:53]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-12 12:40:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1575393002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1575393002/1

[commit-bot: I haz the power, 2016-01-12 12:43:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 12:43:42]

Dry run: This issue passed the CQ dry run.

[Sergiy Byelozyorov, 2016-01-12 15:03:56]

lgtm w/ comment

https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/api.py:143: self.builders,
Where is this populated? Is it always guaranteed to contain compatible bot
configs? If someone adds a bot that is incompatible - will presubmit catch that?

[Paweł Hajdan Jr., 2016-01-12 15:05:39]

https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/api.py:143: self.builders,
On 2016/01/12 at 15:03:56, Sergiy Byelozyorov wrote:
> Where is this populated?

We rely on existing assumptions - the original code was also referring to
self.builders. This patch does not change that.

> Is it always guaranteed to contain compatible bot configs? If someone adds a
bot that is incompatible - will presubmit catch that?

Yes, that's why this patch adds asserts.

[Sergiy Byelozyorov, 2016-01-12 15:10:28]

LGTM

https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/api.py (right):

https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/api.py:143: self.builders,
On 2016/01/12 15:05:38, Paweł Hajdan Jr. wrote:
> On 2016/01/12 at 15:03:56, Sergiy Byelozyorov wrote:
> > Where is this populated?
> 
> We rely on existing assumptions - the original code was also referring to
> self.builders. This patch does not change that.
Thanks for pointing this out. I didn't notice it at first.

> > Is it always guaranteed to contain compatible bot configs? If someone adds a
> bot that is incompatible - will presubmit catch that?
> 
> Yes, that's why this patch adds asserts.
Great. I just wasn't sure if they will be triggered by some tests.

[Ken Russell (switch to Gerrit), 2016-01-12 18:06:21]

lgtm with comment

https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py
(right):

https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py:30: return
self._consistent_get(self._get, name, default)
This will need to be relaxed or generalized in the future. Properties like
chromium_apply_config and gclient_apply_config have to be computed as the union
of all of those on all of the contained bots.

[Ken Russell (switch to Gerrit), 2016-01-12 18:20:35]

https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py
(right):

https://codereview.chromium.org/1575393002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/bot_config_and_test_db.py:30: return
self._consistent_get(self._get, name, default)
On 2016/01/12 18:06:21, Ken Russell wrote:
> This will need to be relaxed or generalized in the future. Properties like
> chromium_apply_config and gclient_apply_config have to be computed as the
union
> of all of those on all of the contained bots.

Pawel and I talked offline about ensuring that these are actually consistent
across all of the builders that are mirrored by a given tryserver. After looking
into this more deeply, I think that's feasible, so this isn't a hard
requirement.

[Paweł Hajdan Jr., 2016-01-13 07:15:28]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-01-13 07:15:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1575393002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1575393002/1

[commit-bot: I haz the power, 2016-01-13 07:18:16]

Description was changed from

==========
Enhance chromium_tests.configure_build for generalized trybot mirroring

BUG=573337
==========

to

==========
Enhance chromium_tests.configure_build for generalized trybot mirroring

BUG=573337

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298235
==========

[commit-bot: I haz the power, 2016-01-13 07:18:17]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298235