Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 1575333004: Propagate the "calls eval" bit from ScopeInfo to lazily-compiled arrow functions (Closed)

Created:
4 years, 11 months ago by adamk
Modified:
4 years, 11 months ago
Reviewers:
Dan Ehrenberg, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Propagate the "calls eval" bit from ScopeInfo to lazily-compiled arrow functions This avoids generating different scopes on the two compilation passes, which results in various delirious side-effects. There's some cleanup to be done in lazy arrow function parsing, but I'd rather do that in a separate patch, with this one targeted at fixing the particular crash. BUG=chromium:572589 LOG=n Committed: https://crrev.com/bcde4e271e300af1ca04e22f76e1edc0680d951e Cr-Commit-Position: refs/heads/master@{#33311}

Patch Set 1 #

Patch Set 2 : Skip test on ignition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/parsing/parser.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-572589.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
adamk
4 years, 11 months ago (2016-01-12 20:05:35 UTC) #2
adamk
4 years, 11 months ago (2016-01-13 19:24:28 UTC) #4
rossberg
lgtm
4 years, 11 months ago (2016-01-14 13:30:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575333004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575333004/20001
4 years, 11 months ago (2016-01-14 18:56:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 19:21:02 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 19:21:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bcde4e271e300af1ca04e22f76e1edc0680d951e
Cr-Commit-Position: refs/heads/master@{#33311}

Powered by Google App Engine
This is Rietveld 408576698