Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1575333002: Fix word-wrap: break-word with fit-content not to break surrogate pairs (Closed)

Created:
4 years, 11 months ago by kojii
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix word-wrap: break-word with fit-content not to break surrogate pairs This patch fixes not to break surrogate pairs when word-wrap: break-word with fit-content. This combination needs a larger fix in crbug.com/380667, but this fix is small enough to take at this point, and it is reasonable to handle trailing pairs when we handle leading pairs. BUG=574577 Committed: https://crrev.com/f417f950dcde37beac951cce67e52025affd22bf Cr-Commit-Position: refs/heads/master@{#369335}

Patch Set 1 #

Patch Set 2 : Test was upstreamed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
kojii
PTAL.
4 years, 11 months ago (2016-01-12 16:48:50 UTC) #5
leviw_travelin_and_unemployed
LGTM! :)
4 years, 11 months ago (2016-01-14 00:25:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575333002/20001
4 years, 11 months ago (2016-01-14 01:21:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-14 03:28:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575333002/20001
4 years, 11 months ago (2016-01-14 04:03:44 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 05:15:28 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 05:16:54 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f417f950dcde37beac951cce67e52025affd22bf
Cr-Commit-Position: refs/heads/master@{#369335}

Powered by Google App Engine
This is Rietveld 408576698