Add CommandBroker::OnTransaction to handle incoming transactions

chromeos/binder/thread.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_BINDER_THREAD_H_
+#define CHROMEOS_BINDER_THREAD_H_
+
+#include "base/macros.h"
+#include "base/message_loop/message_loop.h"
+#include "base/threading/thread.h"
+#include "chromeos/chromeos_export.h"
+
+namespace binder {
+
+class CommandBroker;
+class Driver;
+
+// Thread manages binder-related resources and handles incoming binder commands.

[satorux1, 2016/01/14 05:47:16]

Also document that this opens the binder driver?

[hashimoto, 2016/01/14 06:24:29]

Done.

+class CHROMEOS_EXPORT Thread : public base::Thread,

[satorux1, 2016/01/13 04:33:20]

This is called 'Thread' inside of the 'binder' namespace, which I felt a bit too
generic. Can it have a more descriptive name? for instance if this is for
implementing serevices, maybe ServiceThread

[hashimoto, 2016/01/13 05:46:46]

binder::Thread is a "binder thread" in the same sense as the thread managed by
DBusThreadManager is called the "D-Bus thread".
It's not only for implementing services, but also to make transactions with
services implemented by other processes, by posting a task to this thread from
IO-prohibited threads like the UI thread.

+                               public base::MessageLoopForIO::Watcher {

[satorux1, 2016/01/14 05:47:16]

Maybe IpcThread?

[hashimoto, 2016/01/14 06:24:29]

Done.

+ public:
+  Thread();
+  ~Thread() override;
+
+  Driver* driver() { return driver_.get(); }
+  CommandBroker* command_broker() { return command_broker_.get(); }
+  bool initialized() const { return initialized_; }
+
+  // Starts this thread.

[satorux1, 2016/01/13 04:33:21]

document the return value?

[hashimoto, 2016/01/13 05:46:46]

Done.

+  bool Start();
+
+  // base::MessageLoopIO::Watcher override:
+  void OnFileCanReadWithoutBlocking(int fd) override;
+  void OnFileCanWriteWithoutBlocking(int fd) override;
+
+ protected:
+  // base::Thread override:

[satorux1, 2016/01/13 04:33:21]

nit: 'overrides' may be a bit more common?

[hashimoto, 2016/01/13 05:46:46]

Done.

+  void Init() override;
+  void CleanUp() override;
+
+ private:
+  scoped_ptr<Driver> driver_;
+  scoped_ptr<CommandBroker> command_broker_;
+  scoped_ptr<base::MessageLoopForIO::FileDescriptorWatcher> watcher_;
+  bool initialized_ = false;
+
+  DISALLOW_COPY_AND_ASSIGN(Thread);
+};
+
+}  // namespace binder
+
+#endif  // CHROMEOS_BINDER_THREAD_H_