Add CommandBroker::OnTransaction to handle incoming transactions

chromeos/binder/command_broker.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_BINDER_COMMAND_BROKER_H_
 #define CHROMEOS_BINDER_COMMAND_BROKER_H_
 
 #include <stdint.h>
 
 #include <utility>
@@ skipping 14 matching lines @@
 // Issues appropriate outgoing commands to perform required tasks, and
 // dispatches incoming commands to appropriate objects.
 // Usually this class lives as long as the corresponding thread.
 // TODO(hashimoto): Add code to handle incoming commands (e.g. transactions).
 class CHROMEOS_EXPORT CommandBroker
     : public CommandStream::IncomingCommandHandler {
  public:
   explicit CommandBroker(Driver* driver);
   ~CommandBroker() override;
 
+  // Tells the driver that the current thread entered command handling loop.

[satorux1, 2016/01/13 04:33:20]

Please document the return value here and elsewhere too

[hashimoto, 2016/01/13 05:46:46]

Done.

+  bool EnterLooper();
+
+  // Tells the driver that the current thread exited command handling loop.
+  bool ExitLooper();
+
+  // Fetches incoming commands and handles them.
+  bool PollCommands();
+
   // Performs transaction with the remote object specified by the handle.
   // Returns true on success. If not one-way transaction, this method blocks
   // until the target object sends a reply.
   bool Transact(int32_t handle,
                 const TransactionData& request,
                 scoped_ptr<TransactionData>* reply);
 
   // Increments the ref-count of a remote object specified by |handle|.
   void AddReference(int32_t handle);
 
   // Decrements the ref-count of a remote object specified by |handle|.
   void ReleaseReference(int32_t handle);
 
   // Returns a closure which decrements the ref-count of a remote object.
   // It's safe to run the returned closure even after the destruction of this
   // object.
   base::Closure GetReleaseReferenceClosure(int32_t handle);
 
   // CommandStream::IncomingCommandHandler override:
+  bool OnTransaction(const TransactionData& data) override;
   void OnReply(scoped_ptr<TransactionData> data) override;
   void OnDeadReply() override;
   void OnTransactionComplete() override;
   void OnIncrementWeakReference(void* ptr, void* cookie) override;
   void OnIncrementStrongReference(void* ptr, void* cookie) override;
   void OnDecrementStrongReference(void* ptr, void* cookie) override;
   void OnDecrementWeakReference(void* ptr, void* cookie) override;
   void OnFailedReply() override;
 
  private:
@@ skipping 15 matching lines @@
   scoped_ptr<TransactionData> response_data_;
 
   base::WeakPtrFactory<CommandBroker> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CommandBroker);
 };
 
 }  // namespace binder
 
 #endif  // CHROMEOS_BINDER_COMMAND_BROKER_H_