content/renderer/service_worker/service_worker_context_client.cc - Issue 1575283003: Move notification click event dispatching out of ServiceWorkerVersion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 1575283003: Move notification click event dispatching out of ServiceWorkerVersion. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@swversion-ipc-refactor

Patch Set: rebase and use DispatchSimpleEvent Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/service_worker/service_worker_context_client.cc

diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc

index 348e8093ab2dc5bbbe91d820e0b3897377d564c9..8b55a3c8728875bfe172af6501fdccdf83f8017d 100644

--- a/content/renderer/service_worker/service_worker_context_client.cc

+++ b/content/renderer/service_worker/service_worker_context_client.cc

@@ -521,7 +521,7 @@ void ServiceWorkerContextClient::didHandleNotificationClickEvent(

int request_id,

blink::WebServiceWorkerEventResult result) {

Send(new ServiceWorkerHostMsg_NotificationClickEventFinished(

- GetRoutingID(), request_id));

+ GetRoutingID(), request_id, result));

}

void ServiceWorkerContextClient::didHandlePushEvent(

« no previous file with comments | « content/common/service_worker/service_worker_messages.h ('k') | no next file » | no next file with comments »