Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1575273002: Triage a few cps-ir failures (Closed)

Created:
4 years, 11 months ago by sra1
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Triage a few cps-ir failures Added similar tests that don't rely on instances of List<T> carrying T. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a23c0c2fb579c0140d764ddac6f8bfe9d05ebce0

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -38 lines) Patch
M tests/language/language_dart2js.status View 1 chunk +5 lines, -4 lines 0 comments Download
M tests/language/type_variable_closure2_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
A tests/language/type_variable_closure3_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A + tests/language/type_variable_closure4_test.dart View 2 chunks +1 line, -13 lines 0 comments Download
A + tests/language/type_variable_field_initializer2_test.dart View 2 chunks +6 lines, -4 lines 0 comments Download
A + tests/language/type_variable_field_initializer_closure2_test.dart View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
4 years, 11 months ago (2016-01-12 01:09:27 UTC) #4
Siggi Cherem (dart-lang)
lgtm
4 years, 11 months ago (2016-01-12 01:46:51 UTC) #5
sra1
4 years, 11 months ago (2016-01-12 02:52:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
a23c0c2fb579c0140d764ddac6f8bfe9d05ebce0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698