More source position tests

More source position tests

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/903709eb97b8cd9913643b24614bbb7e9816267e

[Cutch, 2016-01-11 21:02:51]

Description was changed from

==========
More source position tests

BUG=
==========

to

==========
More source position tests

BUG=
==========

[Cutch, 2016-01-11 21:02:51]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-01-11 22:03:22]

https://codereview.chromium.org/1575193002/diff/20001/runtime/vm/flow_graph_b...
File runtime/vm/flow_graph_builder_test.cc (right):

https://codereview.chromium.org/1575193002/diff/20001/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder_test.cc:14: #define DUMP_EXPECT(condition)        
                                        \
Maybe DUMP_ASSERT since this now behaves like ASSERT not EXPECT.

https://codereview.chromium.org/1575193002/diff/20001/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder_test.cc:98: // Expect to find at least one ctatic
call at |line| and |column|. The
ctatic -> static

https://codereview.chromium.org/1575193002/diff/20001/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder_test.cc:396:
spt.FuzzyInstructionMatchAt("Constant", 4, 10);
This is the position of "x", should be that of "10"

https://codereview.chromium.org/1575193002/diff/20001/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder_test.cc:401:
spt.FuzzyInstructionMatchAt("Constant", 5, 9);
This is the position of "y", should be that of "5"

[Cutch, 2016-01-11 22:14:58]

https://codereview.chromium.org/1575193002/diff/20001/runtime/vm/flow_graph_b...
File runtime/vm/flow_graph_builder_test.cc (right):

https://codereview.chromium.org/1575193002/diff/20001/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder_test.cc:14: #define DUMP_EXPECT(condition)        
                                        \
On 2016/01/11 22:03:22, rmacnak wrote:
> Maybe DUMP_ASSERT since this now behaves like ASSERT not EXPECT.

Done.

https://codereview.chromium.org/1575193002/diff/20001/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder_test.cc:98: // Expect to find at least one ctatic
call at |line| and |column|. The
On 2016/01/11 22:03:22, rmacnak wrote:
> ctatic -> static

Done.

https://codereview.chromium.org/1575193002/diff/20001/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder_test.cc:396:
spt.FuzzyInstructionMatchAt("Constant", 4, 10);
On 2016/01/11 22:03:22, rmacnak wrote:
> This is the position of "x", should be that of "10"

Done.

https://codereview.chromium.org/1575193002/diff/20001/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder_test.cc:401:
spt.FuzzyInstructionMatchAt("Constant", 5, 9);
On 2016/01/11 22:03:22, rmacnak wrote:
> This is the position of "y", should be that of "5"

Done.

[rmacnak, 2016-01-11 22:16:35]

lgtm

[Cutch, 2016-01-11 22:18:26]

Description was changed from

==========
More source position tests

BUG=
==========

to

==========
More source position tests

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/903709eb97b8cd9913643b24614bbb7e9816267e
==========

[Cutch, 2016-01-11 22:18:27]

Committed patchset #3 (id:40001) manually as
903709eb97b8cd9913643b24614bbb7e9816267e (presubmit successful).