Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 1575173005: checking and inference of null coalescing operator, fixes #24564 and fixes #25387 (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 11 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

checking and inference of null coalescing operator, fixes #24564 and fixes #25387 R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/0549def77d398d22260e15576cb9abf310bc90e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
4 years, 11 months ago (2016-01-12 23:40:17 UTC) #2
Leaf
lgtm, thanks!
4 years, 11 months ago (2016-01-12 23:46:27 UTC) #3
Jennifer Messerly
4 years, 11 months ago (2016-01-12 23:50:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0549def77d398d22260e15576cb9abf310bc90e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698