Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: components/sync_driver/startup_controller.h

Issue 1575153004: [Sync] Simplify sync startup behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@setup
Patch Set: Rebase. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/startup_controller.h
diff --git a/components/sync_driver/startup_controller.h b/components/sync_driver/startup_controller.h
index c64275048096171e2bb302f2e7d67c738a7c54a1..6d6993a37e9c2e0ab6d767ffe75942582de802c8 100644
--- a/components/sync_driver/startup_controller.h
+++ b/components/sync_driver/startup_controller.h
@@ -35,8 +35,7 @@ enum ProfileSyncServiceStartBehavior {
// to as "the backend").
class StartupController {
public:
- StartupController(ProfileSyncServiceStartBehavior start_behavior,
- const ProfileOAuth2TokenService* token_service,
+ StartupController(const ProfileOAuth2TokenService* token_service,
const sync_driver::SyncPrefs* sync_prefs,
const SigninManagerWrapper* signin,
base::Closure start_backend);
@@ -64,7 +63,6 @@ class StartupController {
void set_setup_in_progress(bool in_progress);
bool IsSetupInProgress() const { return setup_in_progress_; }
- bool auto_start_enabled() const { return auto_start_enabled_; }
base::Time start_backend_time() const { return start_backend_time_; }
std::string GetBackendInitializationStateString() const;
@@ -98,12 +96,6 @@ class StartupController {
// due to explicit requests to do so via set_setup_in_progress.
bool setup_in_progress_;
- // If true, we want to automatically start sync signin whenever we have
- // credentials (user doesn't need to go through the startup flow). This is
- // typically enabled on platforms (like ChromeOS) that have their own
- // distinct signin flow.
- const bool auto_start_enabled_;
-
const sync_driver::SyncPrefs* sync_prefs_;
const ProfileOAuth2TokenService* token_service_;
@@ -122,9 +114,6 @@ class StartupController {
// Used to compute preferred_types from SyncPrefs as-needed.
syncer::ModelTypeSet registered_types_;
- // True before calling |start_backend_| for the first time. False after that.
- bool first_start_;
-
base::WeakPtrFactory<StartupController> weak_factory_;
};
« no previous file with comments | « components/browser_sync/browser/profile_sync_service_unittest.cc ('k') | components/sync_driver/startup_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698