Issue 1575153003: Remove -Wno-logical-op-parentheses for fusl build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1575153003: Remove -Wno-logical-op-parentheses for fusl build (Closed)

Created:
4 years, 11 months ago by kulakowski

Modified:
4 years, 11 months ago

Reviewers:
viettrungluu

CC:
mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove -Wno-logical-op-parentheses for fusl build R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9ad90deb0d26b59e07dae72efbe62a1d8bf25f48

Patch Set 1 #

Total comments: 1

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -15 lines)			Patch
M	fusl/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	fusl/src/internal/shgetc.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fusl/src/locale/iconv.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fusl/src/locale/locale_map.c	View	1 chunk	+3 lines, -3 lines	1 comment	Download
M	fusl/src/passwd/getgr_a.c	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	fusl/src/passwd/getpw_a.c	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	fusl/src/thread/pthread_cancel.c	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

lgtm https://codereview.chromium.org/1575153003/diff/1/fusl/src/locale/locale_map.c File fusl/src/locale/locale_map.c (right): https://codereview.chromium.org/1575153003/diff/1/fusl/src/locale/locale_map.c#newcode38 fusl/src/locale/locale_map.c:38: ((val = getenv("LC_ALL")) && *val) || This makes ...

4 years, 11 months ago (2016-01-12 18:43:18 UTC) #2

kulakowski

4 years, 11 months ago (2016-01-12 19:55:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9ad90deb0d26b59e07dae72efbe62a1d8bf25f48 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages