Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1874)

Issue 1575133003: [parser] fix null-dereference in DoExpression rewriting (Closed)

Created:
4 years, 11 months ago by caitp (gmail)
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] fix null-dereference in DoExpression rewriting BUG=v8:4661, v8:4488 LOG=N R=adamk@chromium.org, rossberg@chromium.org, jkummerow@chromium.org Committed: https://crrev.com/d3fe473b92d924e5d6bf6231d7244a1017e08725 Cr-Commit-Position: refs/heads/master@{#33250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M src/parsing/parser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/do-expressions.js View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
caitp (gmail)
Hi, PTAL This fixes the crash reported by anba
4 years, 11 months ago (2016-01-12 18:17:11 UTC) #2
caitp (gmail)
On 2016/01/12 18:17:11, caitp wrote: > Hi, PTAL > > This fixes the crash reported ...
4 years, 11 months ago (2016-01-12 18:39:48 UTC) #3
caitp (gmail)
On 2016/01/12 18:39:48, caitp wrote: > On 2016/01/12 18:17:11, caitp wrote: > > Hi, PTAL ...
4 years, 11 months ago (2016-01-12 18:49:25 UTC) #4
adamk
lgtm
4 years, 11 months ago (2016-01-12 19:28:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575133003/1
4 years, 11 months ago (2016-01-12 19:29:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 19:53:39 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 19:54:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3fe473b92d924e5d6bf6231d7244a1017e08725
Cr-Commit-Position: refs/heads/master@{#33250}

Powered by Google App Engine
This is Rietveld 408576698