Issue 157513002: Fix webkit test expectation wrt whitespaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 157513002: Fix webkit test expectation wrt whitespaces. (Closed)

Created:
6 years, 10 months ago by Yang

Modified:
6 years, 10 months ago

Reviewers:
Michael Starzinger, Michael Achenbach

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix webkit test expectation wrt whitespaces. A newer version of the test in question can be found in mjsunit/third_party/. R=mstarzinger@chromium.org

Patch Set 1 #

Patch Set 2 : updated expectation instead #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -13 lines)			Patch
	M	test/webkit/string-trim-expected.txt	View	1	1 chunk	+31 lines, -13 lines	0 comments	Download
	M	test/webkit/webkit.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

I think we should update string-trim-expected.txt instead. Adding machenbach@ for his opinion.

6 years, 10 months ago (2014-02-07 12:57:08 UTC) #2

Yang

On 2014/02/07 12:57:08, Michael Starzinger wrote: > I think we should update string-trim-expected.txt instead. Adding ...

6 years, 10 months ago (2014-02-07 13:00:02 UTC) #3

Yang

On 2014/02/07 13:00:02, Yang wrote: > On 2014/02/07 12:57:08, Michael Starzinger wrote: > > I ...

6 years, 10 months ago (2014-02-07 13:21:00 UTC) #4

Yang

6 years, 10 months ago (2014-02-07 13:53:33 UTC) #5

On 2014/02/07 13:21:00, Yang wrote:
> On 2014/02/07 13:00:02, Yang wrote:
> > On 2014/02/07 12:57:08, Michael Starzinger wrote:
> > > I think we should update string-trim-expected.txt instead. Adding
> machenbach@
> > > for his opinion.
> > 
> > For now I'm updating the expectation file.
> 
> Test262 doesn't regard NEL as white space. I have to mark those tests as well
> and will file a bug on test262.

Disregard this. After some more investigation I came to the conclusion that NEL
should not be a whitespace, since the spec requires unicode whitespace to have
category Zs.

Expand Messages | Collapse Messages