Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1575123002: Revert of DevTools: fix toolbar <select> background in Dark theme (Closed)

Created:
4 years, 11 months ago by caseq
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: fix toolbar <select> background in Dark theme (patchset #1 id:1 of https://codereview.chromium.org/1567203004/ ) Reason for revert: This was a bad fix, breaks non-white toolbars (i.e. filter bar). Original issue's description: > DevTools: fix toolbar <select> background in Dark theme > > BUG=572706 > TBR=pfeldman@chromium.org > > Committed: https://crrev.com/50f67380499ef03afa7ebd83bbcfc9868791f1f3 > Cr-Commit-Position: refs/heads/master@{#368523} TBR=pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=572706 Committed: https://crrev.com/e1dd33eb5dbb3176155c86608e8c816bae4efb3b Cr-Commit-Position: refs/heads/master@{#368632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
caseq
Created Revert of DevTools: fix toolbar <select> background in Dark theme
4 years, 11 months ago (2016-01-11 18:05:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575123002/1
4 years, 11 months ago (2016-01-11 18:05:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575123002/1
4 years, 11 months ago (2016-01-11 18:32:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575123002/1
4 years, 11 months ago (2016-01-11 19:03:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 19:10:52 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 19:12:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1dd33eb5dbb3176155c86608e8c816bae4efb3b
Cr-Commit-Position: refs/heads/master@{#368632}

Powered by Google App Engine
This is Rietveld 408576698