Issue 1575113002: Implementation for Look Up on Force Touch. If the user force touched a word in the web content the …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1575113002: Implementation for Look Up on Force Touch. If the user force touched a word in the web content the … (Closed)

Created:
4 years, 11 months ago by shrike

Modified:
4 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

Implementation for Look Up on Force Touch. If the user force touched a word in the web content the Look Up dialog should pop up for the word. BUG=481890 Review URL: https://codereview.chromium.org/1528153004 Cr-Commit-Position: refs/heads/master@{#368481} (cherry picked from commit 927f27305d77ff600a505aa33d586ca8246f1614) Committed: https://chromium.googlesource.com/chromium/src/+/a93bb2b2733693591178941e52615ad6eed4480c

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -1 line)			Patch
M	base/mac/sdk_forward_declarations.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.mm	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/base/cocoa/base_view.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	ui/base/cocoa/base_view.mm	View	2 chunks	+17 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

shrike

4 years, 11 months ago (2016-01-11 18:03:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a93bb2b2733693591178941e52615ad6eed4480c.