Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 1575103003: dart2js cps: Remove inlining from TypePropagator. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Remove inlining from TypePropagator. It seems wasteful to do inlining in two places. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/d432ec78c0c17de056c48b779b5feff7682d26cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -87 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +1 line, -87 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
asgerf
4 years, 11 months ago (2016-01-11 22:43:06 UTC) #3
Kevin Millikin (Google)
LGTM.
4 years, 11 months ago (2016-01-12 00:21:46 UTC) #4
asgerf
4 years, 11 months ago (2016-01-12 01:50:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d432ec78c0c17de056c48b779b5feff7682d26cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698