Chromium Code Reviews

Unified Diff: src/compiler/ppc/code-generator-ppc.cc

Issue 1575103002: PPC: [wasm] Fixes for embedded constant pools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase after committing code refactor separately. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ppc/code-generator-ppc.cc
diff --git a/src/compiler/ppc/code-generator-ppc.cc b/src/compiler/ppc/code-generator-ppc.cc
index 70b38c4d662c617003b70e89a890536c1dcd9f1f..5cfa2e6ff766bf0d2f7b55609f30a55754f238dc 100644
--- a/src/compiler/ppc/code-generator-ppc.cc
+++ b/src/compiler/ppc/code-generator-ppc.cc
@@ -1545,7 +1545,10 @@ void CodeGenerator::AssemblePrologue() {
} else if (descriptor->IsJSFunctionCall()) {
__ Prologue(this->info()->GeneratePreagedPrologue(), ip);
} else if (frame()->needs_frame()) {
- __ StubPrologue(ip);
+ // TODO(mbrandy): Detect the case where we're not generating an
+ // exported wasm function -- so that we can leverage ip to set up
+ // the constant pool pointer register.
titzer 2016/01/13 09:17:40 To detect the compilation of a WASM function, you
+ __ StubPrologue();
} else {
frame()->SetElidedFrameSizeInSlots(0);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine