Issue 1575048: SPDY: Change Chrome code to support new NPN protocols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1575048: SPDY: Change Chrome code to support new NPN protocols. (Closed)

Created:
10 years, 8 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews

Visibility:
Public.

Description

SPDY: Change Chrome code to support new NPN protocols. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44961

Patch Set 1 #

Total comments: 1

Patch Set 2 : oops #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
M	net/http/http_network_layer.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	net/http/http_network_transaction.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/socket/ssl_client_socket.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

agl

10 years, 8 months ago (2010-04-19 20:44:13 UTC) #2

LGTM

http://codereview.chromium.org/1575048/diff/1/4
File net/socket/ssl_client_socket.h (right):

http://codereview.chromium.org/1575048/diff/1/4#newcode65
net/socket/ssl_client_socket.h:65: } else if (proto_string == "spdy" ||
proto_string == "spdy/1.1") {
"spdy/1"

Expand Messages | Collapse Messages