Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: third_party/WebKit/Source/core/style/BorderValue.h

Issue 1574933002: Changed type of border-width longhands from unsigned to float. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added trivial tests safe to rebaseline to TestExpectations Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/BorderValue.h
diff --git a/third_party/WebKit/Source/core/style/BorderValue.h b/third_party/WebKit/Source/core/style/BorderValue.h
index 1713110cf47c567fb45f7334f7687ebf57ec759f..0f32600c53decb422105c2f8059164e575c49652 100644
--- a/third_party/WebKit/Source/core/style/BorderValue.h
+++ b/third_party/WebKit/Source/core/style/BorderValue.h
@@ -37,9 +37,9 @@ class BorderValue {
friend class ComputedStyle;
public:
BorderValue()
- : m_color(0)
+ : m_width(3)
+ , m_color(0)
, m_colorIsCurrentColor(true)
- , m_width(3)
, m_style(BNONE)
, m_isAuto(AUTO_OFF)
{
@@ -88,16 +88,16 @@ public:
StyleColor color() const { return m_colorIsCurrentColor ? StyleColor::currentColor() : StyleColor(m_color); }
- int width() const { return m_width; }
+ float width() const { return m_width; }
EBorderStyle style() const { return static_cast<EBorderStyle>(m_style); }
void setStyle(EBorderStyle style) { m_style = style; }
protected:
+ float m_width;
Color m_color;
unsigned m_colorIsCurrentColor : 1;
- unsigned m_width : 26;
unsigned m_style : 4; // EBorderStyle
// This is only used by OutlineValue but moved here to keep the bits packed.
« no previous file with comments | « third_party/WebKit/Source/core/style/BorderData.h ('k') | third_party/WebKit/Source/core/style/CollapsedBorderValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698