third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h - Issue 1574933002: Changed type of border-width longhands from unsigned to float.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h

Issue 1574933002: Changed type of border-width longhands from unsigned to float. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added trivial tests safe to rebaseline to TestExpectations Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h

index 130ece80a33acb7455009261d2803a7f77020dd2..01a303867e966daaa4d2dade995407742b5b03db 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h

+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h

@@ -148,7 +148,7 @@ T StyleBuilderConverter::convertLineWidth(StyleResolverState& state, const CSSVa

double result = primitiveValue.computeLength<double>(state.cssToLengthConversionData());

if (result > 0.0 && result < 1.0)

return 1.0;

- return clampTo<T>(roundForImpreciseConversion<T>(result), defaultMinimumForClamp<T>(), defaultMaximumForClamp<T>());

+ return clampTo<T>(roundForImpreciseConversion<T>(result), 0, defaultMaximumForClamp<T>());

}

ASSERT_NOT_REACHED();

return 0;