third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 1574933002: Changed type of border-width longhands from unsigned to float.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1574933002: Changed type of border-width longhands from unsigned to float. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed test rebaselines, will add them to TestExpectations instead Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h » ('j') | third_party/WebKit/Source/core/layout/LayoutTableCell.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 0f46d4d73f789debc6bb726893096afbec2f623a..ca9aa9c1746da91ee97d6fe17239068b6d56577b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -436,8 +436,8 @@ LayoutUnit LayoutBox::scrollWidth() const

// For objects with visible overflow, this matches IE.

// FIXME: Need to work right with writing modes.

if (style()->isLeftToRightDirection())

- return std::max(clientWidth(), layoutOverflowRect().maxX() - borderLeft());

- return clientWidth() - std::min(LayoutUnit(), layoutOverflowRect().x() - borderLeft());

+ return std::max(clientWidth(), static_cast<LayoutUnit>((layoutOverflowRect().maxX() - borderLeft())));

leviw_travelin_and_unemployed 2016/02/02 02:20:18 Echo-ing the static_cast comment (use the construc

+ return clientWidth() - std::min(LayoutUnit(), static_cast<LayoutUnit>((layoutOverflowRect().x() - borderLeft())));

}

LayoutUnit LayoutBox::scrollHeight() const

@@ -446,7 +446,7 @@ LayoutUnit LayoutBox::scrollHeight() const

return layer()->scrollableArea()->scrollHeight();

// For objects with visible overflow, this matches IE.

// FIXME: Need to work right with writing modes.

- return std::max(clientHeight(), layoutOverflowRect().maxY() - borderTop());

+ return std::max(clientHeight(), static_cast<LayoutUnit>((layoutOverflowRect().maxY() - borderTop())));

}

LayoutUnit LayoutBox::scrollLeft() const