third_party/WebKit/Source/core/paint/BoxPainter.cpp - Issue 1574933002: Changed type of border-width longhands from unsigned to float.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BoxPainter.cpp

Issue 1574933002: Changed type of border-width longhands from unsigned to float. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made transitions use fractional border widths, added assert that border widths are positive, and r… Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutTableCell.cpp ('k') | third_party/WebKit/Source/core/style/BorderData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/BoxPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/BoxPainter.cpp b/third_party/WebKit/Source/core/paint/BoxPainter.cpp

index a5e8c3a03af4f1d4f0ca2656936a65049e40b7f0..9ba4c50a686a8ad70bb7e4952528875b21e9a638 100644

--- a/third_party/WebKit/Source/core/paint/BoxPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/BoxPainter.cpp

@@ -364,8 +364,8 @@ void BoxPainter::paintFillLayer(const LayoutBoxModelObject& obj, const PaintInfo

clipToBorder.emplace(obj, paintInfo, rect, border, ApplyToContext);

}

- int bLeft = includeLeftEdge ? obj.borderLeft() : 0;

- int bRight = includeRightEdge ? obj.borderRight() : 0;

+ int bLeft = includeLeftEdge ? obj.borderLeft().toInt() : 0;

+ int bRight = includeRightEdge ? obj.borderRight().toInt() : 0;

LayoutUnit pLeft = includeLeftEdge ? obj.paddingLeft() : LayoutUnit();

LayoutUnit pRight = includeRightEdge ? obj.paddingRight() : LayoutUnit();