third_party/WebKit/Source/core/layout/LayoutTable.cpp - Issue 1574933002: Changed type of border-width longhands from unsigned to float.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTable.cpp

Issue 1574933002: Changed type of border-width longhands from unsigned to float. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made transitions use fractional border widths, added assert that border widths are positive, and r… Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutTable.h ('k') | third_party/WebKit/Source/core/layout/LayoutTableCell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTable.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTable.cpp b/third_party/WebKit/Source/core/layout/LayoutTable.cpp

index ee60327808ceb5e09c86185a008eee044de4e431..cbc471fa2bcd48ae31d8f214971047a41f6a4701 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTable.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTable.cpp

@@ -918,7 +918,7 @@ int LayoutTable::calcBorderStart() const

if (!numEffCols())

return 0;

- int borderWidth = 0;

+ float borderWidth = 0;

const BorderValue& tableStartBorder = style()->borderStart();

if (tableStartBorder.style() == BHIDDEN)

@@ -972,7 +972,7 @@ int LayoutTable::calcBorderEnd() const

if (!numEffCols())

return 0;

- int borderWidth = 0;

+ float borderWidth = 0;

const BorderValue& tableEndBorder = style()->borderEnd();

if (tableEndBorder.style() == BHIDDEN)

@@ -1026,7 +1026,7 @@ void LayoutTable::recalcBordersInRowDirection()

m_borderEnd = calcBorderEnd();

}

-int LayoutTable::borderBefore() const

+LayoutUnit LayoutTable::borderBefore() const

{

if (collapseBorders()) {

recalcSectionsIfNeeded();

@@ -1035,7 +1035,7 @@ int LayoutTable::borderBefore() const

return LayoutBlock::borderBefore();

}

-int LayoutTable::borderAfter() const

+LayoutUnit LayoutTable::borderAfter() const

{

if (collapseBorders()) {

recalcSectionsIfNeeded();