third_party/WebKit/Source/core/style/CollapsedBorderValue.h - Issue 1574933002: Changed type of border-width longhands from unsigned to float.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/style/CollapsedBorderValue.h

Issue 1574933002: Changed type of border-width longhands from unsigned to float. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added trivial tests safe to rebaseline to TestExpectations Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)

3 * (C) 2000 Antti Koivisto (koivisto@kde.org)	3 * (C) 2000 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Dirk Mueller (mueller@kde.org)	4 * (C) 2000 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.	5 * Copyright (C) 2003, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.

6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)	6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)

7 *	7 *

8 * This library is free software; you can redistribute it and/or	8 * This library is free software; you can redistribute it and/or

9 * modify it under the terms of the GNU Library General Public	9 * modify it under the terms of the GNU Library General Public

10 * License as published by the Free Software Foundation; either	10 * License as published by the Free Software Foundation; either

(...skipping 67 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
78 bool shouldPaint(const CollapsedBorderValue& tableCurrentBorderValue) const	78 bool shouldPaint(const CollapsedBorderValue& tableCurrentBorderValue) const

79 {	79 {

80 // Invisible borders are not cached so painters see visible borders only .	80 // Invisible borders are not cached so painters see visible borders only .

81 ASSERT(isVisible());	81 ASSERT(isVisible());

82 return isSameIgnoringColor(tableCurrentBorderValue);	82 return isSameIgnoringColor(tableCurrentBorderValue);

83 }	83 }

84	84

85 private:	85 private:

86 Color m_color;	86 Color m_color;

87 unsigned m_colorIsCurrentColor : 1;	87 unsigned m_colorIsCurrentColor : 1;

	88 // TODO(bugsnash): change m_width to float

88 unsigned m_width : 23;	89 unsigned m_width : 23;

89 unsigned m_style : 4; // EBorderStyle	90 unsigned m_style : 4; // EBorderStyle

90 unsigned m_precedence : 3; // EBorderPrecedence	91 unsigned m_precedence : 3; // EBorderPrecedence

91 unsigned m_transparent : 1;	92 unsigned m_transparent : 1;

92 };	93 };

93	94

94 } // namespace blink	95 } // namespace blink

95	96

96 #endif // CollapsedBorderValue_h	97 #endif // CollapsedBorderValue_h

OLD	NEW

« no previous file with comments | « third_party/WebKit/Source/core/style/BorderValue.h ('k') | third_party/WebKit/Source/core/style/ComputedStyle.h » ('j') | no next file with comments »